Eliminate the use of public_test_dep!
#747
Merged
+763
−772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
public-test-deps
branch
from
db67528 to
e14d392
Compare
Replace `public_test_dep!` by placing optionally public items into new modules, then controlling what is exported with the `public-test-deps` feature. This is nicer for automatic formatting and diagnostics. This is a reland of 2e2a925 ("Eliminate the use of `public_test_dep!`"), which was reverted in 47e50fd ('Revert "Eliminate the use of..."') due to a bug exposed at [1]. This was fixed in [2], so the cleanup should be able to be applied again. [1]: rust-lang/rust#128691 [2]: rust-lang/rust#135278
tgross35
force-pushed
the
public-test-deps
branch
from
e14d392 to
a2494f1
Compare
|
Could this be reverted until the issues with this change are resolved? |
|
Let me see if I can get it fixed today since the same issue is blocking future progress with |
|
rust-lang/rust#135501 should be ready to go, which unblocks this. Assuming that can merge in the near future, I will get #752 upstream right after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
public_test_dep!by placing optionally public items into new modules, then controlling what is exported with thepublic-test-depsfeature.This is nicer for automatic formatting and diagnostics.
This is a reland of 2e2a925 ("Eliminate the use of
public_test_dep!"), which was reverted in 47e50fd ('Revert "Eliminate the use of..."') due to a bug exposed at 1. This was fixed in 2, so the cleanup should be able to be applied again.