Fix handling of variables in goal for new alias clauses #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new clauses for alias types (`<X as Y>::Z: Trait :- T: Trait, <X as Y>::Z == T` etc.) were generated using the provided goal, without regard for bound variables. This led to e.g. the new test failing in the recursive solver. Alternatively, it might be better to generate the clauses without using the specific types in the goal.
|
@bors r+ |
|
📌 Commit 3b10bb1 has been approved by |
|
☀️ Test successful - checks-actions |
bors bot
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Dec 7, 2020
6597: Upgrade Chalk r=flodiebold a=flodiebold Also make overflow depth and max type size configurable through env variables. This can be helpful at least for debugging. Tests currently fail because of rust-lang/chalk#656, so we'll need to wait for the next update to merge this. Co-authored-by: Florian Diebold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new clauses for alias types (
<X as Y>::Z: Trait :- T: Trait, <X as Y>::Z == Tetc.) were generated using the provided goal, without regard for bound variables. This led to e.g. the new test failing in the recursive solver. Alternatively, it might be better to generate the clauses without using the specific types in the goal.(CC #568.)