Fix built-in Fn impls when generics are involved #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackh726
reviewed
Jun 23, 2020
tests/test/fn_def.rs
Outdated
|
|
||
| goal { | ||
| exists<T> { Normalize(<foo<T> as FnOnce<(T,)>>::Output -> T) } | ||
| } yields[SolverChoice::recursive()] { |
There was a problem hiding this comment.
Is this associated type ambiguity for SLG? If so, can you add a comment (next to the wrong output)?
There was a problem hiding this comment.
Oh hm actually I just added that while debugging, let me check whether it fails.
There was a problem hiding this comment.
No, works fine, I've removed it.
There were two problems: - the FnDef impl was using a wrong substitution for the FnDef (calling `builder.substitution_in_scope()`, which wasn't even necessarily the same number of parameters -- not sure what the intention was there) - when looking for `Normalize` clauses, the self type wasn't generalized (so bound variables were handled wrongly). (This lead to crashes when trying to integrate it in rust-analyzer: rust-lang/rust-analyzer#4982)
jackh726
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems:
builder.substitution_in_scope(), which wasn't even necessarily the samenumber of parameters -- not sure what the intention was there)
Normalizeclauses, the self type wasn't generalized (sobound variables were handled wrongly). (This lead to crashes when trying to
integrate it in rust-analyzer: Bump chalk rust-analyzer#4982)