Make lowering failure tests less fragile #448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current lowering failure tests check that the error message resulting from the lowering attempt matches a given string exactly. This is fine in most cases, but tests which expect parsing errors are incredibly fragile in that the contents of their error messages change whenever the lexer or parser is modified.
This PR makes a small change so that lowering failure tests which produce a parsing error only have to provide the expected error kind (such as "UnrecognizedToken", etc.) instead of a full error message, which makes the tests less fragile to parser/lexer changes.
It's not exactly a beautiful fix, but it at least alleviates the immediate annoyance of tests frequently breaking.