More env overrides #770
Closed
More env overrides #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes cc-rs and pkg-config-rs use the same encoding.
lu-zero
force-pushed
the
more-env-overrides
branch
from
c05bd50 to
f3533be
Compare
|
The CI apparently had a network glitch. |
|
Interesting idea. I'll have to think about it. |
|
This is implemented in an opt-in way by #818. So I don't think we want this anymore. |
|
I looked at the change, you do not want to have this feature opt-in since it would sort of defeat the purpose of having a standard way to pass optional flags to any crate that's using cc-rs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.