-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for wasm32-wasip1-threads #1217
Comments
Sorry I didn't quite get you. cc-rs only compiles the source code and produce an archive, it does not performing linking, so I don't think |
When compiling C or C++ for wasm32-wasip1-threads, it is necessary to include the -pthreads flag. Otherwise, during linking, you will encounter an error such as: note: wasm-ld: error: --shared-memory is disallowed by dlmalloc.o because it was not compiled with 'atomics' or 'bulk-memory' features. |
So Hmmm I didn't know that |
Yes |
In that case, we might want to special case for this target |
Small example: Running the command However, when I replace |
Thanks, I can reproduce this. Will create a PR for it. |
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
The -pthread is required as a flag.
For -D_WASI_EMULATED_MMAN, it is not necessary yet because the Rust compiler does not support it!
The text was updated successfully, but these errors were encountered: