Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing wasip1 build after upgrade to cc-1.0.100 #1109

Closed
Niederb opened this issue Jun 26, 2024 · 5 comments · Fixed by #1114
Closed

Failing wasip1 build after upgrade to cc-1.0.100 #1109

Niederb opened this issue Jun 26, 2024 · 5 comments · Fixed by #1114

Comments

@Niederb
Copy link

Niederb commented Jun 26, 2024

I have a failing build for wasip1 after one of my transitive dependencies upgraded cc to v1.0.100

error occurred: Environment variable WASI_SYSROOT not defined. Download sysroot from github & setup environment variable WASI_SYSROOT targetting the folder.

(See https://github.com/scs/substrate-api-client/actions/runs/9671307108/job/26681692693 for the failing build)
This seems to be caused by this commit: 6a6107a

I'm not quite sure how to fix this. So far we relied on a standard Github runner for our builds and no additional setup for wasi was needed.

@NobodyXu
Copy link
Collaborator

cc @antaalt can you help me with this issue please?

@antaalt
Copy link
Contributor

antaalt commented Jun 26, 2024

I am curious as to how you were building to WASI without a particular setup, for the fix of the build, you can download WASI sysroot from WASI SDK GitHub release pages and setup the WASI_SYSROOT targeting the folder. You will probably still get issues as there is also an issue that need to be fixed with targets

@NobodyXu
Copy link
Collaborator

Hello @Niederb can you try cc 1.0.102 to see if it fixed your issue?

@NobodyXu
Copy link
Collaborator

NobodyXu commented Jun 30, 2024

Ok I think we'd need to make the WASI_SYSROOT optional, since clang on Linux (or maybe just the Ubuntu-latest runner) seems to come with wasi libraries required.

NobodyXu added a commit that referenced this issue Jun 30, 2024
On ubuntu-latest github action runner, it used to work without the environment variable.

Fixed #1109 #1113
@Niederb
Copy link
Author

Niederb commented Jul 1, 2024

Just to confirm: cc 1.0.103 fixed the issue for me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants