Code

Add new feature resolver.#7820

Code

Merged

bors merged 22 commits intorust-lang:masterrust-lang/cargo:masterfrom ehuss:features2-splitehuss/cargo:features2-splitCopy head branch name to clipboardFeb 20, 2020

+2,304-416

Commits

Commits on Feb 20, 2020

• Move rustc target collection out of bcx.

  Show description for 949ecca
  ehuss

  committed
  949ecca

  Copy full SHA for 949ecca

• Add a RequestedFeatures struct to hold cli features.

  Show description for db80baa
  ehuss

  committed
  db80baa

  Copy full SHA for db80baa

• Add new feature resolver.

  ehuss

  committed
  7caa161

  Copy full SHA for 7caa161

• Ensure dev-dep features are unified if any are used.

  Show description for d728f38
  ehuss

  committed
  d728f38

  Copy full SHA for d728f38

• Do not store requested_features in FeatureResolver.

  Show description for a2135fe
  ehuss

  committed
  a2135fe

  Copy full SHA for a2135fe

• Add some comments to help clarify some features stuff from review.

  ehuss

  committed
  3f06823

  Copy full SHA for 3f06823

• Add test for build script being run multiple times.

  ehuss

  committed
  2c8b9fb

  Copy full SHA for 2c8b9fb

• Consolidate -Zpackage-features member iteration logic.

  ehuss

  committed
  76f0d68

  Copy full SHA for 76f0d68

• Add a cyclical dev-dep test.

  ehuss

  committed
  899067f

  Copy full SHA for 899067f

• Add -Zfeatures=all option.

  ehuss

  committed
  da678a7

  Copy full SHA for da678a7

• Add comment explaining dep_kind in compute_deps_custom_build.

  ehuss

  committed
  134aeff

  Copy full SHA for 134aeff

• Rewrite new feature resolver to simplify DepKind handling.

  Show description for 6154645
  ehuss

  committed
  6154645

  Copy full SHA for 6154645

• Fix cargo clean -p crashing with -Zfeatures.

  ehuss

  committed
  6f33738

  Copy full SHA for 6f33738

• Fix bug where required-features didn't work with -Zfeatures=build_dep correctly.

  ehuss

  committed
  8973b95

  Copy full SHA for 8973b95

• Change have_dev_units from a bool to enum HasDevUnits for clarity.

  ehuss

  committed
  e0d64f9

  Copy full SHA for e0d64f9

• Change for_build_dep from a bool to enum FeaturesFor for clarity.

  ehuss

  committed
  137642c

  Copy full SHA for 137642c

• Compute dep_for_build in one place.

  ehuss

  committed
  b7c0e2e

  Copy full SHA for b7c0e2e

• Try to remove some rightwards drift.

  ehuss

  committed
  ffb13a5

  Copy full SHA for ffb13a5

• Try to clarify some things about UnitFor build flags.

  ehuss

  committed
  2cec46e

  Copy full SHA for 2cec46e

• Add comment trying to explain recursion and optional dependencies.

  ehuss

  committed
  df0ae18

  Copy full SHA for df0ae18

• Add comment on relationship of RunCustomBuild and UnitFor::host.

  ehuss

  committed
  3d6b5b1

  Copy full SHA for 3d6b5b1

• Fix bug where an optional dependency is disabled in one fork, and enabled in another.

  ehuss

  committed
  4d0fda7

  Copy full SHA for 4d0fda7