Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the output of cargo -Z help #7717

Merged

Conversation

giraffate
Copy link
Contributor

--registry flag is already stabilized at 737382d.

@rust-highfive
Copy link

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2019
@@ -32,7 +32,7 @@ Available unstable (nightly-only) flags:
-Z avoid-dev-deps -- Avoid installing dev-dependencies if possible
-Z minimal-versions -- Install minimal dependency versions instead of maximum
-Z no-index-update -- Do not update the registry, avoids a network request for benchmarking
-Z unstable-options -- Allow the usage of unstable options such as --registry
-Z unstable-options -- Allow the usage of unstable options such as --build-plan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, maybe build-plan isn't such a good alternative given #7614. Maybe just remove the "such as…", as this seems like something that will be difficult to keep up-to-date as options get stabilized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just remove the "such as…", as this seems like something that will be difficult to keep up-to-date as options get stabilized.

I agree with you. It seems best to remove "such as ...".

`--registry` flag is already stabilized at 737382d.
@giraffate giraffate force-pushed the registry_flag_is_already_stabilized branch from ee10b91 to ad2969f Compare December 18, 2019 01:29
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Will have to wait for a new nightly to be published before this can be merged to fix Cargo's CI (waiting on rust-lang/rust#67379).

@ehuss
Copy link
Contributor

ehuss commented Dec 19, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Dec 19, 2019

📌 Commit ad2969f has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2019
@bors
Copy link
Contributor

bors commented Dec 19, 2019

⌛ Testing commit ad2969f with merge 7292437...

bors added a commit that referenced this pull request Dec 19, 2019
…r=ehuss

Update the output of `cargo -Z help`

`--registry` flag is already stabilized at 737382d.
@bors
Copy link
Contributor

bors commented Dec 19, 2019

☀️ Test successful - checks-azure
Approved by: ehuss
Pushing 7292437 to master...

@bors bors merged commit ad2969f into rust-lang:master Dec 19, 2019
@giraffate giraffate deleted the registry_flag_is_already_stabilized branch December 20, 2019 03:27
@ehuss ehuss added this to the 1.42.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants