Testssuite #5022
Closed
Testssuite #5022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Excellent @rochamatcomp! Could you do some measurements to test that it actually improves things instead of making them worse? I think the following metrics are interesting (before and after this change):
|
|
Oh, because we'd want to take advantage of incremental compilation, I think it makes sense to do the measurements using the current beta. |
|
rustup show
The time in seconds.
|
|
Awww, awesome, @rochamatcomp ! @alexcrichton seems like a massive win overall to me, what would you think? |
|
Thanks for getting those numbers! I'm game for merging. |
|
@rochamatcomp could you rebase the PR so that it merges cleanly? |
bors
added a commit
that referenced
this pull request
Feb 21, 2018
Reorganize integration tests as one crate with many modules. Issue #4867. Rebased V3 This is an automatic rebase of @rochamatcomp's work in #5022, as requested in [#5038](#5038 (comment)). I take no credit for the changes; I just wanted faster test for my work. :-)
29 tasks
CBenoit
added a commit
to Devolutions/IronRDP
that referenced
this pull request
May 10, 2023
Put all integration tests in a single crate, and organized in modules. This is similar to what was done in `cargo` repository: rust-lang/cargo#5022 (comment) ``` $ rustup show stable-x86_64-unknown-linux-gnu (default) rustc 1.69.0 (84c898d65 2023-04-16) ``` Run on a recent high-end laptop: 12th Gen Intel(R) Core(TM) i9-12900HK Original (multiple integration binaries): - `cargo clean && cargo test --no-run`: 62.893s - `cargo clean && cargo build --lib`: 54.959s - `cargo clean && cargo build --bins`: 55.933s - `cargo test --no-run` (after `cargo build`): 14.472s - `cargo test` (after `cargo test --no-run`): 1.786s - `du -hs target/`: 4.2G After (ironrdp-testsuite): - `cargo clean && cargo test --no-run`: 41.157s (crates with no tests are ignored) - `cargo clean && cargo build --lib`: 53.983s - `cargo clean && cargo build --bins`: 54.482s - `cargo test --no-run` (after `cargo build`): 12.915s - `cargo test` (after `cargo test --no-run`): 0.240s - `du -hs target/`: 3.4G Absolute diff: - `cargo clean && cargo test --no-run`: -21.736s - `cargo clean && cargo build --lib`: -0.976s - `cargo clean && cargo build --bins`: -1.451s - `cargo test --no-run` (after `cargo build`): -1.557s - `cargo test` (after `cargo test --no-run`): -1.546s - `du -hs target/`: -0.8G Relative diff (%): - `cargo clean && cargo test --no-run`: -34.5% - `cargo clean && cargo build --lib`: -1.77% - `cargo clean && cargo build --bins`: -2.59% - `cargo test --no-run` (after `cargo build`): -10.7% - `cargo test` (after `cargo test --no-run`): -86.5% - `du -hs target/`: -19.0%
CBenoit
added a commit
to Devolutions/IronRDP
that referenced
this pull request
May 10, 2023
Put all integration tests in a single crate, and organized in modules. This is similar to what was done in `cargo` repository: rust-lang/cargo#5022 (comment) ``` $ rustup show stable-x86_64-unknown-linux-gnu (default) rustc 1.69.0 (84c898d65 2023-04-16) ``` Run on a recent high-end laptop: 12th Gen Intel(R) Core(TM) i9-12900HK Original (multiple integration binaries): - `cargo clean && cargo test --no-run`: 62.893s - `cargo clean && cargo build --lib`: 54.959s - `cargo clean && cargo build --bins`: 55.933s - `cargo test --no-run` (after `cargo build`): 14.472s - `cargo test` (after `cargo test --no-run`): 1.786s - `du -hs target/`: 4.2G After (ironrdp-testsuite): - `cargo clean && cargo test --no-run`: 41.157s (crates with no tests are ignored) - `cargo clean && cargo build --lib`: 53.983s - `cargo clean && cargo build --bins`: 54.482s - `cargo test --no-run` (after `cargo build`): 12.915s - `cargo test` (after `cargo test --no-run`): 0.240s - `du -hs target/`: 3.4G Absolute diff: - `cargo clean && cargo test --no-run`: -21.736s - `cargo clean && cargo build --lib`: -0.976s - `cargo clean && cargo build --bins`: -1.451s - `cargo test --no-run` (after `cargo build`): -1.557s - `cargo test` (after `cargo test --no-run`): -1.546s - `du -hs target/`: -0.8G Relative diff (%): - `cargo clean && cargo test --no-run`: -34.5% - `cargo clean && cargo build --lib`: -1.77% - `cargo clean && cargo build --bins`: -2.59% - `cargo test --no-run` (after `cargo build`): -10.7% - `cargo test` (after `cargo test --no-run`): -86.5% - `du -hs target/`: -19.0%
CBenoit
added a commit
to Devolutions/IronRDP
that referenced
this pull request
May 11, 2023
Put all integration tests in a single crate, and organized in modules. This is similar to what was done in `cargo` repository: rust-lang/cargo#5022 (comment) ``` $ rustup show stable-x86_64-unknown-linux-gnu (default) rustc 1.69.0 (84c898d65 2023-04-16) ``` Run on a recent high-end laptop: 12th Gen Intel(R) Core(TM) i9-12900HK Original (multiple integration binaries): - `cargo clean && cargo test --no-run`: 62.893s - `cargo clean && cargo build --lib`: 54.959s - `cargo clean && cargo build --bins`: 55.933s - `cargo test --no-run` (after `cargo build`): 14.472s - `cargo test` (after `cargo test --no-run`): 1.786s - `du -hs target/`: 4.2G After (ironrdp-testsuite): - `cargo clean && cargo test --no-run`: 41.157s (crates with no tests are ignored) - `cargo clean && cargo build --lib`: 53.983s - `cargo clean && cargo build --bins`: 54.482s - `cargo test --no-run` (after `cargo build`): 12.915s - `cargo test` (after `cargo test --no-run`): 0.240s - `du -hs target/`: 3.4G Absolute diff: - `cargo clean && cargo test --no-run`: -21.736s - `cargo clean && cargo build --lib`: -0.976s - `cargo clean && cargo build --bins`: -1.451s - `cargo test --no-run` (after `cargo build`): -1.557s - `cargo test` (after `cargo test --no-run`): -1.546s - `du -hs target/`: -0.8G Relative diff (%): - `cargo clean && cargo test --no-run`: -34.5% - `cargo clean && cargo build --lib`: -1.77% - `cargo clean && cargo build --bins`: -2.59% - `cargo test --no-run` (after `cargo build`): -10.7% - `cargo test` (after `cargo test --no-run`): -86.5% - `du -hs target/`: -19.0%
CBenoit
added a commit
to Devolutions/IronRDP
that referenced
this pull request
May 11, 2023
Put all integration tests in a single crate, and organized in modules. This is similar to what was done in `cargo` repository: rust-lang/cargo#5022 (comment) ``` $ rustup show stable-x86_64-unknown-linux-gnu (default) rustc 1.69.0 (84c898d65 2023-04-16) ``` Run on a recent high-end laptop: 12th Gen Intel(R) Core(TM) i9-12900HK Original (multiple integration binaries): - `cargo clean && cargo test --no-run`: 62.893s - `cargo clean && cargo build --lib`: 54.959s - `cargo clean && cargo build --bins`: 55.933s - `cargo test --no-run` (after `cargo build`): 14.472s - `cargo test` (after `cargo test --no-run`): 1.786s - `du -hs target/`: 4.2G After (ironrdp-testsuite): - `cargo clean && cargo test --no-run`: 41.157s (crates with no tests are ignored) - `cargo clean && cargo build --lib`: 53.983s - `cargo clean && cargo build --bins`: 54.482s - `cargo test --no-run` (after `cargo build`): 12.915s - `cargo test` (after `cargo test --no-run`): 0.240s - `du -hs target/`: 3.4G Absolute diff: - `cargo clean && cargo test --no-run`: -21.736s - `cargo clean && cargo build --lib`: -0.976s - `cargo clean && cargo build --bins`: -1.451s - `cargo test --no-run` (after `cargo build`): -1.557s - `cargo test` (after `cargo test --no-run`): -1.546s - `du -hs target/`: -0.8G Relative diff (%): - `cargo clean && cargo test --no-run`: -34.5% - `cargo clean && cargo build --lib`: -1.77% - `cargo clean && cargo build --bins`: -2.59% - `cargo test --no-run` (after `cargo build`): -10.7% - `cargo test` (after `cargo test --no-run`): -86.5% - `du -hs target/`: -19.0%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize integration tests as one crate with many modules #4867.