Document that cargo test --release uses profile.bench #4650
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks! @bors r+ |
|
📌 Commit 7dea9b2 has been approved by |
|
⌛ Testing commit 7dea9b2 with merge a786e037b0809b60e25643921ba1a9100a47e09b... |
|
💔 Test failed - status-appveyor |
|
@bors retry |
Document that cargo test --release uses profile.bench It certainly makes sense but it's still surprising behavior when the docs clearly state `cargo bench` = `profile.bench`, `cargo test` = `profile.test`. Had to dive into the code to figure this out.
|
💔 Test failed - status-appveyor |
|
⌛ Testing commit 7dea9b2 with merge 06f220c79972628eb050598840b41ae00469827d... |
|
💔 Test failed - status-appveyor |
|
Oh, could you also update https://github.com/rust-lang/cargo/blob/master/src/doc/book/src/reference/manifest.md? Turns out, we have two copies of docs in the repo at the moment, and the must be kept in sync 🤷♂️ . See readme in docs folder for an explanation :) |
|
Done. |
|
@bors r+ Thanks! |
|
📌 Commit 4b8249f has been approved by |
Document that cargo test --release uses profile.bench It certainly makes sense but it's still surprising behavior when the docs clearly state `cargo bench` = `profile.bench`, `cargo test` = `profile.test`. Had to dive into the code to figure this out.
|
☀️ Test successful - status-appveyor, status-travis |
It certainly makes sense but it's still surprising behavior when the docs clearly state
cargo bench=profile.bench,cargo test=profile.test. Had to dive into the code to figure this out.