Fix cargo test --doc with dev-deps #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #3468) made this pull request unmergeable. Please resolve the merge conflicts. |
Previously Cargo accidentally didn't pull in dev-dependencies due to the way `cargo test --doc` was interpreted in terms of top-level targets. This PR special cases this situation by ensuring that the doctest intention makes its way all to the backend and the dependencies can be correctly calculated. Closes rust-lang#3422
alexcrichton
force-pushed
the
dev-dep-doc-test
branch
from
9c76f14 to
fb1736e
Compare
|
@bors r+ |
|
📌 Commit fb1736e has been approved by |
bors
added a commit
that referenced
this pull request
Jan 12, 2017
Fix cargo test --doc with dev-deps Previously Cargo accidentally didn't pull in dev-dependencies due to the way `cargo test --doc` was interpreted in terms of top-level targets. This PR special cases this situation by ensuring that the doctest intention makes its way all to the backend and the dependencies can be correctly calculated. Closes #3422
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Cargo accidentally didn't pull in dev-dependencies due to the way
cargo test --docwas interpreted in terms of top-level targets. This PRspecial cases this situation by ensuring that the doctest intention makes its
way all to the backend and the dependencies can be correctly calculated.
Closes #3422