Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show how to set license in guide's example #2169

Closed
wants to merge 1 commit into from

Conversation

edunham
Copy link
Member

@edunham edunham commented Nov 24, 2015

I hope that this will gently remind users that it's best practices to license
their code.

I hope that this will gently remind users that it's best practices to license
their code.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

So, I like this, but I also don't like the idea of picking a specific license in the example.

The other problem is that this doesn't work: Cargo doesn't generate this, which is how the tutorial works.

Maybe we can address this another way?

@alexcrichton
Copy link
Member

I agree that choosing one would be nice to avoid, perhaps something like license = "..." and then a comment pointing where to get a list from?

@apasel422
Copy link
Contributor

This could also incorporate a demonstration of #2013, if it's merged.

@alexcrichton
Copy link
Member

I'm gonna close this for now (been inactive for awhile), but we'll likely revisit if #2013 is rebased/landed as part of the documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants