-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency header in default Cargo.toml #2126
Conversation
Almost any project beyond "hello world" will have some dependencies. Including the `[dependencies]` header by default makes this slightly simpler. For new users of the language, this can potentially save some frustration since crates.io currently does not mention the header, just the line that goes beneath it. For all users, this makes adding the first dependency to a project less of a special case than to subsequent dependencies.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wycats (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Yeah, I've been thinking about this too. I think I'm 👍 |
I wonder if it may be a good idea as well to pre-generate an annotated |
I'm torn. We did that for a while with Bundler, but then you end up just deleting it anyway.... |
Almost any project beyond "hello world" will have some dependencies. Including the `[dependencies]` header by default makes this slightly simpler. For new users of the language, this can potentially save some frustration since crates.io currently does not mention the header, just the line that goes beneath it. For all users, this makes adding the first dependency to a project less of a special case than to subsequent dependencies.
⌛ Testing commit e708411 with merge 6026a18... |
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Almost any project beyond "hello world" will have some dependencies.
Including the
[dependencies]
header by default makes this slightlysimpler.
For new users of the language, this can potentially save some
frustration since crates.io currently does not mention the header, just
the line that goes beneath it.
For all users, this makes adding the first dependency to a project less
of a special case than to subsequent dependencies.