Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build-std): parse as comma-separated list #15065

Merged
merged 2 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/cargo/core/features.rs
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,9 @@ unstable_cli_options!(
avoid_dev_deps: bool = ("Avoid installing dev-dependencies if possible"),
binary_dep_depinfo: bool = ("Track changes to dependency artifacts"),
bindeps: bool = ("Allow Cargo packages to depend on bin, cdylib, and staticlib crates, and use the artifacts built by those crates"),
#[serde(deserialize_with = "deserialize_comma_separated_list")]
build_std: Option<Vec<String>> = ("Enable Cargo to compile the standard library itself as part of a crate graph compilation"),
#[serde(deserialize_with = "deserialize_comma_separated_list")]
build_std_features: Option<Vec<String>> = ("Configure features enabled for the standard library itself when building the standard library"),
cargo_lints: bool = ("Enable the `[lints.cargo]` table"),
checksum_freshness: bool = ("Use a checksum to determine if output is fresh rather than filesystem mtime"),
Expand Down Expand Up @@ -872,6 +874,24 @@ const STABILIZED_LINTS: &str = "The `[lints]` table is now always available.";
const STABILIZED_CHECK_CFG: &str =
"Compile-time checking of conditional (a.k.a. `-Zcheck-cfg`) is now always enabled.";

fn deserialize_comma_separated_list<'de, D>(
deserializer: D,
) -> Result<Option<Vec<String>>, D::Error>
where
D: serde::Deserializer<'de>,
{
let Some(list) = <Option<Vec<String>>>::deserialize(deserializer)? else {
return Ok(None);
};
let v = list
.iter()
.flat_map(|s| s.split(','))
.filter(|s| !s.is_empty())
.map(String::from)
.collect();
Ok(Some(v))
}

#[derive(Debug, Copy, Clone, Default, Deserialize, Ord, PartialOrd, Eq, PartialEq)]
#[serde(default)]
pub struct GitFeatures {
Expand Down
78 changes: 78 additions & 0 deletions tests/testsuite/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2163,3 +2163,81 @@ gitoxide = \"fetch\"
unstable_flags.gitoxide == expect
}
}

#[cargo_test]
fn build_std() {
let gctx = GlobalContextBuilder::new()
.env("CARGO_UNSTABLE_BUILD_STD", "core,std,panic_abort")
.build();
let value = gctx
.get::<Option<cargo::core::CliUnstable>>("unstable")
.unwrap()
.unwrap()
.build_std
.unwrap();
assert_eq!(
value,
vec![
"core".to_string(),
"std".to_string(),
"panic_abort".to_string(),
],
);

let gctx = GlobalContextBuilder::new()
.config_arg("unstable.build-std=['core', 'std,panic_abort']")
.build();
let value = gctx
.get::<Option<cargo::core::CliUnstable>>("unstable")
.unwrap()
.unwrap()
.build_std
.unwrap();
assert_eq!(
value,
vec![
"core".to_string(),
"std".to_string(),
"panic_abort".to_string(),
]
);

let gctx = GlobalContextBuilder::new()
.env(
"CARGO_UNSTABLE_BUILD_STD_FEATURES",
"backtrace,panic-unwind,windows_raw_dylib",
)
.build();
let value = gctx
.get::<Option<cargo::core::CliUnstable>>("unstable")
.unwrap()
.unwrap()
.build_std_features
.unwrap();
assert_eq!(
value,
vec![
"backtrace".to_string(),
"panic-unwind".to_string(),
"windows_raw_dylib".to_string(),
]
);

let gctx = GlobalContextBuilder::new()
.config_arg("unstable.build-std-features=['backtrace', 'panic-unwind,windows_raw_dylib']")
.build();
let value = gctx
.get::<Option<cargo::core::CliUnstable>>("unstable")
.unwrap()
.unwrap()
.build_std_features
.unwrap();
assert_eq!(
value,
vec![
"backtrace".to_string(),
"panic-unwind".to_string(),
"windows_raw_dylib".to_string(),
]
);
}
Loading