Update to rust 2015-03-22 #1440
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wycats (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
| @@ -455,6 +455,7 @@ test!(cross_with_a_build_script { | |||
| "#) | |||
| .file("build.rs", format!(r#" | |||
| use std::env; | |||
| use std::old_path::{{Path, GenericPath}}; | |||
There was a problem hiding this comment.
Is this on purpose double {{}} instead of single {}? Just wondering, I haven't seen this in rust before.
There was a problem hiding this comment.
yes, this is a format string - the escaping is required
There was a problem hiding this comment.
Ahhh, ok, that makes sense. Thanks!
|
This travis failure looks like a flake. This should be good to go. r? @alexcrichton |
|
@bors: r+ Thanks! |
|
📌 Commit 901f66b has been approved by |
|
⌛ Testing commit 901f66b with merge 8b808ff... |
|
💔 Test failed - cargo-mac-32 |
|
Hm those do not look flaky, I haven't seen many of those before, I think that those failures warrant some investigation. |
|
I had to apply this patch to get it to pass tests locally. |
|
@alexcrichton nice, thanks for tracking that down! |
|
💔 Test failed - cargo-win-64 |
|
@bors: retry Now that's a spurious failure |
|
⚡ Previous build results for cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32 are reusable. Rebuilding only cargo-linux-32, cargo-win-64... |
|
that linux travis build really had some trouble O.o |
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64 |
@alexcrichton