Skip to content

Commit

Permalink
chore(ci): cargo-hack --no-dev-deps
Browse files Browse the repository at this point in the history
One thing to note is that the use of the --all-targets flag (that builds
tests/examples) needed to be removed and the --no-dev-deps flag is needed.
This is because the dev-dependencies use versionless manifests that cannot
be read by the old compiler.

That said, we are not running tests with the old compiler, so I don't see
a problem if the test suite cannot be built on the old compiler.

Co-authored-by: Taiki Endo <[email protected]>
  • Loading branch information
weihanglo and taiki-e committed Jan 25, 2024
1 parent 55b72ab commit b0a8a2c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -258,4 +258,4 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: taiki-e/install-action@cargo-hack
- run: cargo hack check --all-targets --rust-version --workspace --no-private
- run: cargo hack check --rust-version --workspace --no-private --no-dev-deps

0 comments on commit b0a8a2c

Please sign in to comment.