Select all matching targets, not just the first one

This means that all binaries will be built. Additionally, tests have
been updated to validate the new behavior.

src/cargo/core/compiler/unit_dependencies.rs

@@ -266,30 +266,29 @@ fn compute_deps<'a, 'cfg>(
             Some(pkg) => pkg,
             None => continue,
         };
-        let lib = match pkg.targets().iter().find(|t| t.is_lib() || t.is_bin()) {
-            Some(t) => t,
-            None => continue,
-        };
-        let mode = check_or_build_mode(unit.mode, lib);
-        let dep_unit_for = unit_for.with_for_host(lib.for_host());
-
-        if bcx.config.cli_unstable().dual_proc_macros && lib.proc_macro() && !unit.kind.is_host() {
-            let unit_dep = new_unit_dep(state, unit, pkg, lib, dep_unit_for, unit.kind, mode)?;
-            ret.push(unit_dep);
-            let unit_dep =
-                new_unit_dep(state, unit, pkg, lib, dep_unit_for, CompileKind::Host, mode)?;
-            ret.push(unit_dep);
-        } else {
-            let unit_dep = new_unit_dep(
-                state,
-                unit,
-                pkg,
-                lib,
-                dep_unit_for,
-                unit.kind.for_target(lib),
-                mode,
-            )?;
-            ret.push(unit_dep);
+
+        for target in pkg.targets().iter().filter(|t| t.is_lib() || t.is_bin()) {
+            let mode = check_or_build_mode(unit.mode, target);
+            let dep_unit_for = unit_for.with_for_host(target.for_host());
+            let proc_macros = bcx.config.cli_unstable().dual_proc_macros && target.proc_macro();
+
+            let kinds = if proc_macros && !unit.kind.is_host() {
+                vec![unit.kind, CompileKind::Host]
+            } else {
+                vec![unit.kind.for_target(target)]
+            };
+
+            for kind in kinds {
+                ret.push(new_unit_dep(
+                    state,
+                    unit,
+                    pkg,
+                    target,
+                    dep_unit_for,
+                    kind,
+                    mode,
+                )?);
+            }
         }
     }
 

tests/testsuite/build.rs

@@ -2194,8 +2194,6 @@ fn rebuild_preserves_out_dir() {
 
 #[cargo_test]
 fn dep_no_libs() {
-    let exe_name = format!("bar{}", env::consts::EXE_SUFFIX);
-
     let foo = project()
         .file(
             "Cargo.toml",
@@ -2211,11 +2209,17 @@ fn dep_no_libs() {
         )
         .file("src/lib.rs", "pub fn bar() -> i32 { 1 }")
         .file("bar/Cargo.toml", &basic_manifest("bar", "0.0.0"))
-        .file("bar/src/main.rs", "fn main() {}")
+        .file("bar/src/bin/baz.rs", "fn main() {}")
+        .file("bar/src/bin/qux.rs", "fn main() {}")
         .build();
 
     foo.cargo("build").run();
-    assert!(foo.target_debug_dir().join(exe_name).exists());
+
+    let baz = format!("baz{}", env::consts::EXE_SUFFIX);
+    assert!(foo.target_debug_dir().join(baz).exists());
+
+    let qux = format!("qux{}", env::consts::EXE_SUFFIX);
+    assert!(foo.target_debug_dir().join(qux).exists());
 }
 
 #[cargo_test]
@@ -3400,8 +3404,8 @@ fn build_all_workspace_implicit_examples() {
     assert!(!p.bin("b").is_file());
     assert!(p.bin("examples/c").is_file());
     assert!(p.bin("examples/d").is_file());
-    assert!(!p.bin("e").is_file());
-    assert!(!p.bin("f").is_file());
+    assert!(p.bin("e").is_file());
+    assert!(p.bin("f").is_file());
     assert!(p.bin("examples/g").is_file());
     assert!(p.bin("examples/h").is_file());
 }

tests/testsuite/test.rs

@@ -1688,9 +1688,13 @@ fn selective_testing() {
 
     println!("whole");
     p.cargo("test")
+        // NOTE: The compilation order appears to be unpredictable.
+        // Therefore, the test will sporadically fail. How do I solve for this?
+        // I've tried reducing parallelism to 1 without success.
         .with_stderr(
-            "\
-[COMPILING] foo v0.0.1 ([CWD])
+"   Compiling d2 v0.0.1 ([CWD]/d2)
+   Compiling d1 v0.0.1 ([CWD]/d1)
+   Compiling foo v0.0.1 ([CWD])
 [FINISHED] test [unoptimized + debuginfo] target(s) in [..]
 [RUNNING] target/debug/deps/foo-[..][EXE]",
         )

tests/testsuite/workspaces.rs

@@ -179,7 +179,7 @@ fn inferred_path_dep() {
 
     p.cargo("build").run();
     assert!(p.bin("foo").is_file());
-    assert!(!p.bin("bar").is_file());
+    assert!(p.bin("bar").is_file());
 
     p.cargo("build").cwd("bar").run();
     assert!(p.bin("foo").is_file());
@@ -228,13 +228,13 @@ fn transitive_path_dep() {
 
     p.cargo("build").run();
     assert!(p.bin("foo").is_file());
-    assert!(!p.bin("bar").is_file());
-    assert!(!p.bin("baz").is_file());
+    assert!(p.bin("bar").is_file());
+    assert!(p.bin("baz").is_file());
 
     p.cargo("build").cwd("bar").run();
     assert!(p.bin("foo").is_file());
     assert!(p.bin("bar").is_file());
-    assert!(!p.bin("baz").is_file());
+    assert!(p.bin("baz").is_file());
 
     p.cargo("build").cwd("baz").run();
     assert!(p.bin("foo").is_file());