Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error Handling Project Group Announcement post #690

Merged
merged 5 commits into from
Sep 18, 2020
Merged

Add Error Handling Project Group Announcement post #690

merged 5 commits into from
Sep 18, 2020

Conversation

seanchen1991
Copy link
Member

This PR adds the announcement post for the Error Handling project group: rust-lang/rfcs#2965.

Please let me know if there are any formatting/content changes that need to be made to the post before it can go live!

@seanchen1991 seanchen1991 requested a review from a team as a code owner September 12, 2020 21:12
@jyn514 jyn514 added content An issue related to an article. needs review labels Sep 12, 2020
@pietroalbini
Copy link
Member

We usually did announcements like this on the Inside Rust blog (posts/inside-rust), is there a reason why this is on the main blog?

@seanchen1991
Copy link
Member Author

Nope 😂
My bad. I'll open a PR on the Inside Rust blog.

@pietroalbini
Copy link
Member

@seanchen1991 you don't need to open another PR :)

Just reopen this and move the file to posts/inside-rust.

@seanchen1991 seanchen1991 reopened this Sep 14, 2020
@seanchen1991
Copy link
Member Author

This should be ready to merge now 🙂

@Mark-Simulacrum
Copy link
Member

I think we should hold off until the repository has the readme filled out and such.

Copy link
Contributor

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for going dark @seanchen1991! This looks good to me

@seanchen1991
Copy link
Member Author

@Mark-Simulacrum This should be good to be merged now 🙂

@Mark-Simulacrum
Copy link
Member

Exciting!

@Mark-Simulacrum Mark-Simulacrum merged commit ce1c719 into rust-lang:master Sep 18, 2020
@seanchen1991 seanchen1991 deleted the erpg-announcement branch September 18, 2020 17:24
jackh726 pushed a commit to jackh726/blog.rust-lang.org that referenced this pull request Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content An issue related to an article. needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants