Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gimli dependencies #421

Merged
merged 3 commits into from
May 4, 2021
Merged

Update gimli dependencies #421

merged 3 commits into from
May 4, 2021

Conversation

philipc
Copy link
Contributor

@philipc philipc commented May 2, 2021

No description provided.

@philipc philipc force-pushed the gimli branch 4 times, most recently from 0f5a4dd to 1151c3b Compare May 2, 2021 09:03
@philipc philipc force-pushed the gimli branch 2 times, most recently from ca5ec39 to 9ba86eb Compare May 2, 2021 09:32
@philipc philipc marked this pull request as ready for review May 2, 2021 11:05
@philipc
Copy link
Contributor Author

philipc commented May 2, 2021

I don't understand why the object dependency update is failing for cargo test --features libbacktrace, and I can't reproduce it locally.

@alexcrichton
Copy link
Member

I've bisected this as a "regression" which was introduced in rust-lang/rust#84635. I don't think that PR is actually breaking. The "breakage" is probably because of rust-lang/cargo#9418 which does something to reorder CGUs or symbols or something like that.

My suspicion is that this is a bug in libbacktrace itself. Locally testing resetting the libbacktrace submodule to the master branch (current master, which IIRC has a lot of changes) it fixes the issue. That leads me to conclude that this is indeed a libbacktrace issue.

Actually, I can confirm that a cherry-pick of ianlancetaylor/libbacktrace@430dc8b fixes the issue.


So I think there's an interesting question of what to do with this at this point. The libbacktrace implementation of this crate at this point is long-unmaintained and it's falling behind in terms of features (compression, split-debuginfo, etc). I don't think there's any reason to turn it on over the gimli implementation now that gimli has baked for quite some time.

I think, personally, it's time to remove this implementation.

Would you be ok commenting out the libbacktrace tests in CI? That'll get this green and I can do the removal myself in a future PR.

@philipc
Copy link
Contributor Author

philipc commented May 3, 2021

Done, thanks for looking into that.

@alexcrichton alexcrichton merged commit fbb9fc1 into rust-lang:master May 4, 2021
@philipc philipc deleted the gimli branch May 5, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants