Switch lazy_static over to mutable statics instead of UnsafeCell on nightly #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimundi
force-pushed
the
destructor_drop
branch
from
4fe25de to
a308da1
Compare
Kimundi
changed the title
Kimundi
force-pushed
the
destructor_drop
branch
from
3e1f63e to
8fff063
Compare
|
Alright, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rfcs#1440 got merged, so we can now get rid of the UnsafeCell in favor of directly having a drop type in a mutable static.
However, since the current
UnsafeCellimpl got also legitimized by the RFC, the current plan is to not merge this PR until either thedrop_types_in_constfeature gets stabilized, or is at least old enough to not require the most current version of the compiler.