Enable use of cargo-fuzz without a separate workspace #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Jan 7, 2024
This addresses #345. Currently, `cargo-fuzz` defines an independent workspace ``` [workspace] members = ["."] ``` which introduces some issues like caching setup, separate linting configs, etc. The main reason for this seems to be a custom config for `profile.release.debug` which is allowed to be changed only at the root Cargo.toml of the workspace. This commit adds a workaround for that by supplying `--config profile.release.debug=true`. If users need to preserve the old behavior they can provide the flag `--fuzzing-workspace=true` during `cargo fuzz init`
|
I'm excited for the next release, having them in the same workspace would allow me to delete my |
|
I can cut a release in a little bit, but FWIW nothing is stopping you from manually removing the workspace declaration in |
kdarkhan
added a commit
to kdarkhan/mdbook-i18n-helpers
that referenced
this pull request
Jan 25, 2024
With the changes from rust-fuzz/cargo-fuzz#357 merged, `fuzz` dir now can be a part of the workspace.
kdarkhan
added a commit
to kdarkhan/mdbook-i18n-helpers
that referenced
this pull request
Jan 26, 2024
With the changes from rust-fuzz/cargo-fuzz#357 merged, `fuzz` dir now can be a part of the workspace.
|
Thanks for releasing the new version @fitzgen About changing the workspace structure without the new release - that would probably not work with the older version of I don't know about the reason for setting the flag but it will be ignored in child workspace.
|
kdarkhan
added a commit
to google/mdbook-i18n-helpers
that referenced
this pull request
Jan 30, 2024
With the changes from rust-fuzz/cargo-fuzz#357 merged, `fuzz` dir now can be a part of the workspace.
kdarkhan
added a commit
to kdarkhan/mdbook-i18n-helpers
that referenced
this pull request
Jan 30, 2024
With the changes from rust-fuzz/cargo-fuzz#357 merged, `fuzz` dir now can be a part of the workspace.
kdarkhan
added a commit
to google/mdbook-i18n-helpers
that referenced
this pull request
Feb 2, 2024
With the changes from rust-fuzz/cargo-fuzz#357 merged, `fuzz` dir now can be a part of the workspace.
kdarkhan
added a commit
to kdarkhan/mdbook-i18n-helpers
that referenced
this pull request
Feb 6, 2024
With the changes from rust-fuzz/cargo-fuzz#357 merged, `fuzz` dir now can be a part of the workspace.
kdarkhan
added a commit
to kdarkhan/pulldown-cmark
that referenced
this pull request
Aug 30, 2024
This is possible because of the change introduced in rust-fuzz/cargo-fuzz#357. Using the same workspace enables reusing same deps and sharing cache between members. It also has better editor support.
kdarkhan
added a commit
to kdarkhan/pulldown-cmark
that referenced
this pull request
Aug 31, 2024
This is possible because of the change introduced in rust-fuzz/cargo-fuzz#357. Using the same workspace enables reusing same deps and sharing cache between members. It also has better editor support.
kdarkhan
added a commit
to kdarkhan/pulldown-cmark
that referenced
this pull request
Aug 31, 2024
This is possible because of the change introduced in rust-fuzz/cargo-fuzz#357. Using the same workspace enables reusing same deps and sharing cache between members. It also has better editor support.
kdarkhan
added a commit
to kdarkhan/pulldown-cmark
that referenced
this pull request
Sep 5, 2024
This has the benefit of sharing the build cache and better editor support. Previously it was not possible to do it in `cargo-fuzz` but became possible after rust-fuzz/cargo-fuzz#357.
kdarkhan
added a commit
to kdarkhan/pulldown-cmark
that referenced
this pull request
Sep 5, 2024
This has the benefit of sharing the build cache and better editor support. Previously it was not possible to do it in `cargo-fuzz` but became possible after rust-fuzz/cargo-fuzz#357.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #345. Currently,
cargo-fuzzdefines an independent workspacewhich introduces some issues like caching setup, separate linting configs, etc.
The main reason for this seems to be a custom config for
profile.release.debugwhich is allowed to be changed only at the root Cargo.toml of the workspace. This commit adds a workaround for that by supplying--config profile.release.debug=true.In order to not break workflows of the existing users I introduced a new flag which allows to fallback to the old behavior.