Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax fuzz dir name constraint #262

Merged
merged 1 commit into from
May 12, 2021
Merged

Relax fuzz dir name constraint #262

merged 1 commit into from
May 12, 2021

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented May 8, 2021 •
edited
Loading

Fixes #238

I am not fully aware of the internals of this project and the chosen approach might not be the best. But hey, it is working.

cargo fuzz run --fuzz-dir some_fuzz_project_dir someTarget

Manishearth
Manishearth approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea! Will also wait for another maintainer to approve.

@nagisa
Copy link
Member

nagisa commented May 10, 2021

SGTM.

fitzgen
fitzgen reviewed May 10, 2021
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good; thanks! Would you also be interested in adding support for --fuzz-dir to all the other subcommands for consistency?

@c410-f3r
Copy link
Contributor Author

Yes but I only ever used init and run so I don't know which command should receive the additional fuzz-dir parameter. Can you make a list? For example:

Comand Project dir Fuzz dir
init X X
run X
bar
foo X

@fitzgen
Copy link
Member

fitzgen commented May 10, 2021

I think all subcommands would benefit from a --fuzz-dir <dir> flag:

  • add
  • build
  • cmin
  • coverage
  • fmt
  • init
  • list
  • run
  • tmin

They all require executing some kind of command inside the (canonically named) crate/fuzz directory.

@c410-f3r
Copy link
Contributor Author

c410-f3r commented May 10, 2021 •
edited
Loading

I think all subcommands would benefit from a --fuzz-dir flag:

Makes life easier. Thanks

@c410-f3r c410-f3r changed the title Relax fuzz dir name constraint for run command Relax fuzz dir name constraint May 12, 2021
@c410-f3r
Copy link
Contributor Author

ping @fitzgen

fitzgen
fitzgen approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding the flag to all the other subcommands!

@c410-f3r
Copy link
Contributor Author

@fitzgen Thanks!

If possible, could you guys publish a new version of libfuzzer and cargo-fuzz on crates.io in the near future?

@fitzgen fitzgen merged commit a7052a0 into rust-fuzz:master May 12, 2021
@fitzgen
Copy link
Member

fitzgen commented May 12, 2021

Yeah, I have one thing I want to get into libfuzzer-sys before the next publish, but I expect I'll have the PR up tomorrow.

@fitzgen
Copy link
Member

fitzgen commented May 13, 2021

Published!

@c410-f3r
Copy link
Contributor Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for non-standard project directories
4 participants
@c410-f3r @nagisa @fitzgen @Manishearth