Allow stripping of dead code #260
Conversation
src/options.rs
Outdated
|
|
||
| /// Dead code is linked by default to prevent a potential error with some | ||
| /// optimized targets. This flag allows you to opt out of it. | ||
| #[structopt(long = "strip-dead-code")] |
There was a problem hiding this comment.
nitpick: structopt should infer this long name, so this line shouldn't be necessary here.
There was a problem hiding this comment.
I am not clear why, but without specifying the name, the run_with_crash test fails, but only when it's run as part of the full test suite.
There was a problem hiding this comment.
Ah, I figured out the issue I was running into. Because the test ids (and therefore directories) are non-deterministic, on repeated runs, I the run_*_with_crash tests can end up looking at the wrong output.
Running cargo clean between tests is a workaround, but I'll open another PR to make the project directories deterministic, as the failures are very confusing.
Edit: Nevermind, making the directories deterministic is not enough. I'm not sure the actual issue, but it seems related to tests getting the wrong output, e.g. run_with_crash can fail, and shows output that appears to be from run_without_sanitizer_with_crash. Limiting test-threads to 1 causes the failures to go away.
The `-Clink-dead-code` flag was added to fix an error with certain targets. However, it can also cause problems. Example: You depend on crate A which links to library B. A includes an unused reference to `B::foo`. If the specific version of B we have is missing `foo`, we now get a linker error whereas we would not if stripping dead code.
paholg
force-pushed
the
allow-not-linking-dead-code
branch
from
52878e5 to
d3d6253
Compare
|
@fitzgen Thanks for the quick review / merge! If it's not too much trouble, would you mind doing a version bump / publish soon? |
The
-Clink-dead-codeflag was added to fix an error with certaintargets.
However, it can also cause problems.
Example: You depend on crate A which links to library B. A includes an
unused reference to
B::foo. If the specific version of B we have ismissing
foo, we now get a linker error whereas we would not ifstripping dead code.