Implement persistent mode + use panic::set_hook() + many more #137
Conversation
Performance goes from ~2200/s to 17000/s on my i7-7700HQ while fuzzing the `url_read` target. closes rust-fuzz#131 partially addresses rust-fuzz#31
See rationnal here: rust-fuzz/honggfuzz-rs@abe2b4c closes rust-fuzz#134
It doesn't change much performance but why not
PaulGrandperrin
changed the title
|
This is a lot of changes at once. |
There was a problem hiding this comment.
Amazing work, thanks so much @PaulGrandperrin 🙇
So sorry it took almost two weeks to get a review for this!
src/lib.rs
Outdated
| /// ```rust,ignore | ||
| /// # extern crate afl; | ||
| /// # use afl::fuzz; | ||
| /// # fn main() { |
There was a problem hiding this comment.
I'm fine as-is, but considering users are going to need the main function, I wouldn't be opposed to showing it for these examples.
src/lib.rs
Outdated
| /// | ||
| /// This slice contains a "random" quantity of "random" data. | ||
| /// | ||
| /// ```rust,ignore |
There was a problem hiding this comment.
Instead of rust,ignore, this can be rust,no_run to ensure it compiles, but won't attempt to run which is what we want
https://doc.rust-lang.org/book/first-edition/documentation.html#running-documentation-tests
|
bors r+ |
137: Implement persistent mode + use panic::set_hook() + many more r=frewsxcv a=PaulGrandperrin See the commits for more details Performance goes from ~2400/s to ~19500/s on `url_read` target on i7-7700HQ. Co-authored-by: Paul Grandperrin <[email protected]> Co-authored-by: Corey Farwell <[email protected]>
Build succeeded |
|
Awesome! I'll also release a new version of honggfuzz-rs to exactly match this new API. |
See the commits for more details
Performance goes from ~2400/s to ~19500/s on
url_readtarget on i7-7700HQ.