-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recent_index
, oldest_index
, oldest,
and is_filled
to HistoryBuffer API
#347
Conversation
I was just about to fork this repo because I needed these. I will be happy to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes themselves look excellent. In fact I already pointed my project to this commit because I needed the "oldest()" api and it passes my application tests.
Before this can be merged though it should:
- Refresh with a merge from main
- Modify the changelog with a note on the additions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the slow review! Life has been keeping me busy lately.
Thanks for making the change! I took a closer look before merging, and I have one last question (sorry!). What is the use-case of the |
The index methods can be used with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! Sorry it took so long to get it merged.
I added some convenience methods to the HistoryBuffer API to help keep track of both ends of the buffer.