Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare e-h-nb-1.0.0-alpha.0 release #410

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Prepare e-h-nb-1.0.0-alpha.0 release #410

merged 1 commit into from
Sep 27, 2022

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Sep 27, 2022

No description provided.

@eldruin eldruin requested a review from a team as a code owner September 27, 2022 17:59
@rust-highfive
Copy link

r? @therealprof

(rust-highfive has picked a reviewer for you, use r? to override)

Dirbaio
Dirbaio reviewed Sep 27, 2022
View reviewed changes
embedded-hal-nb/CHANGELOG.md Outdated

...

## [v0.1.0-alpha.0] - 2022-09-27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.1.0 or v1.0.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, should be fixed now.

@eldruin eldruin force-pushed the e-h-nb-1.0.0-alpha.0 branch from 12c7697 to 77324ab Compare September 27, 2022 20:01
Dirbaio
Dirbaio approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 !!!

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 27, 2022

Build succeeded:

@bors bors bot merged commit d9bcf29 into rust-embedded:master Sep 27, 2022
@burrbull
Copy link
Member

e-h-1.0-alpha.9 ?

@eldruin
Copy link
Member Author

eldruin commented Sep 28, 2022

@burrbull there has certainly be enough changes. Let's do that after an embedded-can release: #411

@eldruin eldruin deleted the e-h-nb-1.0.0-alpha.0 branch September 28, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dirbaio Dirbaio Dirbaio approved these changes

Assignees

@therealprof therealprof

Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eldruin @rust-highfive @burrbull @Dirbaio @therealprof