Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canonicalize URLs #68

Merged
merged 2 commits into from
Nov 4, 2018
Merged

canonicalize URLs #68

merged 2 commits into from
Nov 4, 2018

Conversation

japaric
Copy link
Member

@japaric japaric commented Nov 4, 2018

as per #55

closes #55

this PR also ignores print.html when linkcheck-ing as done in
rust-embedded/discovery#142

as per #55

closes #55
to avoid errors caused by bug rust-lang/mdBook#789
@japaric japaric requested a review from a team as a code owner November 4, 2018 22:50
@japaric japaric added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Nov 4, 2018
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Nov 4, 2018
68: canonicalize URLs r=therealprof a=japaric

as per #55

closes #55

this PR also ignores print.html when `linkcheck`-ing as done in
rust-embedded/discovery#142

Co-authored-by: Jorge Aparicio <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 4, 2018

Build succeeded

@bors bors bot merged commit cf66108 into master Nov 4, 2018
@bors bors bot deleted the canonicalize branch November 4, 2018 23:36
@japaric japaric mentioned this pull request Nov 5, 2018
njmartin10 pushed a commit to njmartin10/book that referenced this pull request Nov 10, 2018
68: canonicalize URLs r=therealprof a=japaric

as per rust-embedded#55

closes rust-embedded#55

this PR also ignores print.html when `linkcheck`-ing as done in
rust-embedded/discovery#142

Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canonical link format
2 participants