Remove serde_keypair module
#531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `serde_keypair` module appears to be only used for testing, however it is part of the public API for the `key` module? serde de/serialization is already implemented on `KeyPair` by way of the normal `serde` traits, there is no obvious reason for the `serde_keypair` and the `KeyPairWrapper`. Remove the `KeyPairWrapper` and test `KeyPair` serde impls directly.
|
concept ACK. This looks like this module was added in #379 apparently obliviously to the fact that we'd just added the serde impl in #379. Much later we noticed that the original impl was broken, which we fixed in #492. There is a lesson here I guess that we should apply stronger review even to shit that none of us use. |
apoelstra
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done while unsuccessfully trying to solve #514
The
serde_keypairmodule appears to be only used for testing, however it is part of the public API for thekeymodule?serde de/serialization is already implemented on
KeyPairby way of the normalserdetraits, there is no obvious reason for theserde_keypairand theKeyPairWrapper.Remove the
KeyPairWrapperand testKeyPairserde impls directly.