Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitcoin: Tracking PR for release v0.31.0 #2140

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

tcharding
Copy link
Member

In preparation for release of v0.31.0 bump the version number.

The changelog is already up to date because we have done two RC releases.

@tcharding
Copy link
Member Author

tcharding commented Oct 24, 2023

We'll plan to re-tag and release this as 0.31.0 on Friday Oct 27, assuming nobody shows up with things we need to fix.

ref: #2124 (comment)

Let's get this ack'd crew so that we don't get to Friday and have to wait for acks.

@tcharding tcharding changed the title Tracking PR for release of bitcoin v0.31.0 bitconi: Tracking PR for release of v0.31.0 Oct 24, 2023
@tcharding tcharding changed the title bitconi: Tracking PR for release of v0.31.0 bitcoin: Tracking PR for release of v0.31.0 Oct 24, 2023
@tcharding tcharding changed the title bitcoin: Tracking PR for release of v0.31.0 bitcoin: Tracking PR for release v0.31.0 Oct 24, 2023
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f4eb71c743cd1d719d071191061b77df7064eb0e

Copy link
Member

@clarkmoody clarkmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f4eb71c743cd1d719d071191061b77df7064eb0e

Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f4eb71c

Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f4eb71c743cd1d719d071191061b77df7064eb0e

@tcharding
Copy link
Member Author

We found a changelog bug, #2143 needs to merge before this can be considered.

@apoelstra
Copy link
Member

I think the changelog bug is minor enough that we shouldn't do a whole rc over it.

I wouldn't mind cutting a release off of master though without a rc, which contains:

In preparation for release of v0.31.0 bump the version number.

The changelog is already up to date because we have done two RC
releases.
@tcharding tcharding force-pushed the 10-24-release-v0.31.0 branch from f4eb71c to efedf86 Compare October 27, 2023 21:32
@tcharding
Copy link
Member Author

Sweet as, rebased on master. No other changes.

Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK efedf86

@apoelstra
Copy link
Member

Let's do it!

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK efedf86

@apoelstra apoelstra merged commit 60318c4 into rust-bitcoin:master Oct 28, 2023
@apoelstra
Copy link
Member

Tagged and published.

@junderw
Copy link
Contributor

junderw commented Oct 28, 2023

CI says: "too many PRs! No cookie for you!"

@junderw
Copy link
Contributor

junderw commented Oct 28, 2023

Error: Error 422: Validation Failed: {"resource":"Release","code":"custom","field":"body","message":"body is too long (maximum is 125000 characters)"}

@tcharding tcharding deleted the 10-24-release-v0.31.0 branch October 31, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

6 participants