ci: automated nightly rustfmt scheduled/manual PRs #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realeinherjar
changed the title
realeinherjar
changed the title
tcharding
previously approved these changes
Oct 21, 2023
|
Nice! Too bad we just missed this week's opportunity to test it :). |
apoelstra
approved these changes
Oct 22, 2023
You can trigger manually as well. |
tcharding
approved these changes
Oct 22, 2023
crywolf
added a commit
to crywolf/rust-bitcoin
that referenced
this pull request
Nov 25, 2023
apoelstra
added a commit
that referenced
this pull request
Nov 26, 2023
5a3f1a6 Remove nightly rustfmt check from pre-commit githook See #2135 (Vojtěch Toman) Pull request description: See #2135 and discussion [#2219#issuecomment-1826437013](#2219 (comment)) ACKs for top commit: Kixunil: ACK 5a3f1a6 apoelstra: ACK 5a3f1a6 Tree-SHA512: 3fabadcbc4f80fb133318138aad8e1baccbeffad57d09fe86ed12f1156e8c9505911f8fc3a785896832fad02e20a366e9d95d37602bdd5fc02d9c715a867cb72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rustfmtchecks from CI andCONTRIBUTING.md. Superseds Remove rustfmt formatting requirement from project #2127rustfmtPR creations manual and every Sunday 00:00 UTC. Closes rustfmt without nightly toolchain #2128. Closes Relax rustfmt rules? #1712.Details
The new
.github/workflows/rustfmt.ymlaction does the following:rustfmtcomponentcargo +nightly fmtwhich format all the codebase with the nightly Rust toolchain writing the changesYYYY-MM-DDformat as an GH action ENV varDATE)rustfmtchanges by create-pull-request GitHub actionDATEautomated rustfmt nightlyrustfmtI did a test run (with
workflow_dispatchand some minor changes to trigger the PR) in my fork.Check how the PR looks in https://github.com/realeinherjar/rust-bitcoin/pull/5
Of course, all of these things can be changed.
They are all suggestions...
Security Disclaimer
We are only introducing a new action, which is quite battle-checked,
peter-evans/create-pull-requestwith ~2k stars and proper maintained.