-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure code for future LLDB support #546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwightguth
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine as far as it goes, so I'm approving, but if we name the lldb script klldb.py, should we rename the gdb script kgdb.py?
Good point - I'll do that then merge if you're happy. |
Yes, that's fine. That's why I approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the infrastructure for future K support of LLDB (#701), but doesn't yet implement the K-specific debugging features. Future PRs can follow on implementing individual debugger support features by hooking into the
dispatch_k
function.The stubbed LLDB plugin as implemented here just attaches to the interpreter, sets a breakpoint before
main
, then drops into the default LLDB REPL. Any K commands (start
,step
etc.) just produce a warning.I'll follow this up with a corresponding frontend PR (similar to runtimeverification/k#2646) that launches
klldb.py
with the appropriate arguments when--debugger
is passed tokrun
on macOS, and updates the documentation accordingly.