Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure code for future LLDB support #546

Merged
merged 14 commits into from
Aug 11, 2022
Merged

Structure code for future LLDB support #546

merged 14 commits into from
Aug 11, 2022

Conversation

Baltoli
Copy link
Contributor

@Baltoli Baltoli commented Aug 10, 2022

This PR sets up the infrastructure for future K support of LLDB (#701), but doesn't yet implement the K-specific debugging features. Future PRs can follow on implementing individual debugger support features by hooking into the dispatch_k function.

The stubbed LLDB plugin as implemented here just attaches to the interpreter, sets a breakpoint before main, then drops into the default LLDB REPL. Any K commands (start, step etc.) just produce a warning.

I'll follow this up with a corresponding frontend PR (similar to runtimeverification/k#2646) that launches klldb.py with the appropriate arguments when --debugger is passed to krun on macOS, and updates the documentation accordingly.

@Baltoli Baltoli marked this pull request as ready for review August 11, 2022 10:19
Copy link
Collaborator

@dwightguth dwightguth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine as far as it goes, so I'm approving, but if we name the lldb script klldb.py, should we rename the gdb script kgdb.py?

@Baltoli
Copy link
Contributor Author

Baltoli commented Aug 11, 2022

Good point - I'll do that then merge if you're happy.

@dwightguth
Copy link
Collaborator

Yes, that's fine. That's why I approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants