Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kup improvements #2957

Merged
merged 6 commits into from
Oct 6, 2022
Merged

kup improvements #2957

merged 6 commits into from
Oct 6, 2022

Conversation

goodlyrottenapple
Copy link
Contributor

@goodlyrottenapple goodlyrottenapple commented Oct 5, 2022

Fixes #2938

  • kup update <package> --version ... and kup install <package> --version ... behave the same now
  • kup list <package> fetches the git history and shows commits/tags

image

@ehildenb
Copy link
Member

ehildenb commented Oct 5, 2022

@goodlyrottenapple can you skip the Merge commits in the output? If that's easy, it would be nice to clean it up a bit.

Also, we should be ready to handle the pagination, but we probably don't need to yet.

@ehildenb
Copy link
Member

ehildenb commented Oct 5, 2022

Any commit with title Merge remote-tracking branch 'origin/develop' can be skipped basically. It would also be nice to just display one commit per version, but that can be later.

@goodlyrottenapple
Copy link
Contributor Author

I can hard code it so that certain commits with a given prefix don't show up in the list. Bear in mind that different repositories, e.g. haskell-backend have different setup and e.g. have no version tags

@goodlyrottenapple
Copy link
Contributor Author

Any commit with title Merge remote-tracking branch 'origin/develop' can be skipped basically

done

@ehildenb
Copy link
Member

ehildenb commented Oct 5, 2022

Long term, we should probably be storing our own database with kup accessible versions, instead of relying on GitHub API, so we can get faster retrieval and storage of the information how we like. But for now this looks good :)

@rv-jenkins rv-jenkins merged commit d66139a into develop Oct 6, 2022
@rv-jenkins rv-jenkins deleted the sam/kup-improvements branch October 6, 2022 09:50
h0nzZik pushed a commit to h0nzZik/k that referenced this pull request Nov 24, 2022
…untimeverification#2398)

* haskell-backend/src/main/native/haskell-backend: 37ad90f61 - Switching out kprove to kprovex (runtimeverification#2856)

* haskell-backend/src/main/native/haskell-backend: ec04f9445 - Bump follow-redirects from 1.13.3 to 1.14.7 in /web (runtimeverification#2958)

* haskell-backend/src/main/native/haskell-backend: 21f5e381c - Update dependency: deps/k_release (runtimeverification#2957)

* haskell-backend/src/main/native/haskell-backend: ff4adf522 - Update dependency: deps/k_release (runtimeverification#2959)

* haskell-backend/src/main/native/haskell-backend: d776afb5a - Add NonExecutable attribute (runtimeverification#2945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants