-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module pyk.kore #2696
Add module pyk.kore #2696
Conversation
c9655ff
to
da871a4
Compare
6d5e359
to
acdd454
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These parser files are very large. I don't feel confident reviewing them. At least not by myself.
Are they generated by any chance?
No. Since the Kore grammar is relatively simple, I wrote the parser manually. |
Looks fine to me on first glance (no deep review of the Kore). I'm sure we'll find problems as we test, but no need to hang up the first version of it too long. |
We likely will want to use some faster parser eventually, but we can cross that bridge when we come to it, and by then we'll have more test-cases we can use. |
Closes #2626
This PR introduces the
pyk.kore
module. It contains:Currently, only syntactic validation is performed on the AST (e.g. identifiers are lexically correct), semantic validation rules described in https://github.com/runtimeverification/haskell-backend/blob/master/docs/kore-syntax.md#validity are not implemented.