Add definedness conditions to some symbolic map rules #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttuegel
approved these changes
Mar 18, 2021
| { | ||
| false | ||
| #Equals | ||
| X:MyId in_keys ( MAP [ Y:MyId <- undef ] ) |
There was a problem hiding this comment.
Can we add rules to simplify this more? (If so, we can do it in another pull request.)
There was a problem hiding this comment.
I noticed this as well. We should look into it as part of another issue I think.
zhengyao-lin
pushed a commit
to zhengyao-lin/k
that referenced
this pull request
Mar 20, 2021
…untimeverification#1324) * haskell-backend/src/main/native/haskell-backend: 62d182b2 - Remove hie.yaml (runtimeverification#1864) * haskell-backend/src/main/native/haskell-backend: c8d22b29 - Update dependency: deps/k_release (runtimeverification#1868) * haskell-backend/src/main/native/haskell-backend: 0aaca590 - Simplification rule for in .Set (runtimeverification#1870) * haskell-backend/src/main/native/haskell-backend: 201aa07b - Added simplification rule for orBool = false (runtimeverification#1871) * haskell-backend/src/main/native/haskell-backend: fc5c8a95 - Argument for all path reachability using merged rules (runtimeverification#1866)
dwightguth
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for #1830