Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create doc page for azure key vault key storage plugin #1611

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

hiawvp
Copy link
Contributor

@hiawvp hiawvp commented Jan 13, 2025

This PR add a documentation page for the new Key Storage Plugin Azure Key Vault Key Storage Plugin

It also adds the link/entry for this new plugin in the sidebar menu and Key Storage external providers index.

@ronaveva
Copy link
Contributor

instead of putting step by step configuration related to azure (since it could get outdated) i would prefer to just specify that

  1. RBAC and Access policies should work
  2. Any permission model would require the necessary access level to admin secrets

This way if the azure UI changes we dont need to go around updating the screenshots

@hiawvp hiawvp marked this pull request as ready for review January 21, 2025 19:14
@ronaveva ronaveva requested a review from fdevans January 22, 2025 18:29
@fdevans fdevans added this to the 5.9.0 milestone Jan 22, 2025
@ronaveva
Copy link
Contributor

@hiawvp azure-vault-show-allowed.png screenshot needs to be updated according to this PR https://github.com/rundeckpro/rundeckpro/pull/4111

@fdevans fdevans requested review from fdevans and ronaveva January 29, 2025 19:07
Copy link
Contributor

@ronaveva ronaveva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdevans fdevans changed the base branch from 4.0.x to 5.9.0 February 5, 2025 16:25
@fdevans fdevans merged commit 21db333 into 5.9.0 Feb 5, 2025
1 check passed
@fdevans fdevans deleted the rpl-233_azure_key_storage_vault_plugin branch February 5, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants