Adapt labels to kubernetes recommended ones

[jonitich]

what

• Set Kubernetes recommended labels.

why

• Align standards.

tests

• I've testes it by rendering the helm chart.

[GMartinez-Sisti]

Hi @jonitich, thank you for the contribution, unfortunately users might be matching the current labels so we can't remove them.

I'll bring this to a discussion on the community so we can decide if it's worth a breaking change, a feature toggle or if it won't go through. I'll update the slack thread id here.

Update: slack thread -> https://cloud-native.slack.com/archives/C07T45G27EZ/p1739283078077209

[jonitich]

Thanks for the quick response @GMartinez-Sisti,
Br,
Joni.

[jonitich]

hi @GMartinez-Sisti, I can see tthe Lint adn Test Charts failing, is there anything I can do about it?

[GMartinez-Sisti]

hi @GMartinez-Sisti, I can see tthe Lint adn Test Charts failing, is there anything I can do about it?

The error is:

✖︎ atlantis => (version: "5.14.0", path: "charts/atlantis") > chart version not ok. Needs a version bump!

This version bump would be dependent on how this PR will be categorized. So no need to worry about this now.

[den-is]

While this PR is not merged I also would recommend splitting selector labels into a different helper snippet. And make it "immutable" (not changeable by the user) - always having two specific labels as shown below.

For example in this well-known chart and hundreds of other well-known charts:
https://github.com/grafana/helm-charts/blob/5bae43a05122dca0dcc20e7d268658092530e5ba/charts/grafana/templates/_helpers.tpl#L78-L84