Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure git to use https instead of ssh. #797

Closed
wants to merge 1 commit into from
Closed

Configure git to use https instead of ssh. #797

wants to merge 1 commit into from

Conversation

andrewjeffree
Copy link

In 711 I implemented write-git-creds and it was suggested that this particular enhancement should be implemented via a separate PR.

However, for that work, it does require the source to be specified as an HTTPS source type. It's relatively trivial to have it work for ssh sources also we just need to run one extra command to configure it which is what this PR adds.

@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #797 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage   72.78%   72.77%   -0.02%     
==========================================
  Files          63       63              
  Lines        4807     4811       +4     
==========================================
+ Hits         3499     3501       +2     
- Misses       1050     1051       +1     
- Partials      258      259       +1
Impacted Files Coverage Δ
server/events/git_cred_writer.go 83.33% <50%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4c439a...2b3ed1f. Read the comment docs.

@andrewjeffree
Copy link
Author

andrewjeffree commented Oct 3, 2019

Closing as my testing wasn't thorough enough and it's not actually working properly. Will open a new one when I've finished testing it more thoroughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant