Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert branch protection feature causing breaking change #3321

Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix: revert branch protection feature causing breaking change #3321

merged 1 commit into from
Apr 11, 2023

Conversation

GenPage
Copy link
Member

@GenPage GenPage commented Apr 11, 2023 •
edited by nitrocode
Loading

what

Currently as it stands in the latest release and since 0.23.2, repositories with branch protections enabled are seeing a breaking change to their workflows.

why

In summary, the GH user used by Atlantis to interface with GitHub API is unable to access the branch protection endpoint unless their permissions are set to Admin. Currently, we only advertise Write access` for the user. See docs

Note: GH Apps are unaffected since they are should be giving Read permissions on repo "Administration"

references

@GenPage
Revert "fix(github): branch protection not supported (#3276)"
6dabc45 
This reverts commit ebc06c1.

Revert "fix: allow `Require Linear History` when selecting merge method (#3211)"

This reverts commit 7a33828.
@GenPage GenPage requested a review from a team as a code owner April 11, 2023 20:35
@github-actions github-actions bot added go Pull requests that update Go code provider/github labels Apr 11, 2023
@GenPage GenPage merged commit 34ad9e9 into main Apr 11, 2023
@GenPage GenPage deleted the revert/gh-merge-branch-protections branch April 11, 2023 20:48
@nitrocode nitrocode added this to the v0.23.5 milestone Apr 12, 2023
This was referenced Apr 12, 2023
Merged
Merged
@GenPage GenPage mentioned this pull request Apr 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code provider/github
Projects
None yet
Milestone
v0.23.5
Development

Successfully merging this pull request may close these issues.

in 0.22.3+, auto-merge only works with admin repo permissions
3 participants
@GenPage @jamengual @nitrocode