Use the "clone_url" provided in the webhook response

[candidson]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

• I'd be willing to implement this feature (contributing guide)

Describe the user story
As a developer, I often want to use the "clone_url" provided in the webhook response. However, based on the different kinds of installations, the base path can be different.

Describe the solution you'd like
I would like to entirely remove the check for the clone_url here:

Describe the drawbacks of your solution

Describe alternatives you've considered

[nitrocode]

Please feel free to propose a PR

[candidson]

Please feel free to propose a PR

I just did: #3124

[nitrocode]

Please fill out the full issue template like the drawbacks. The purpose of this check, according to the comments, is to ensure "the clone url is the same as the repo to avoid something malicious".

• What part of your proposal could continue that behavior?

Let's take a step back.

• What problem are you trying to solve?
• What are you trying to use the web hook's clone url for?
• What vcs are you using?

[candidson]

Hi @nitrocode

Thanks for the feedback. I like the idea of taking a step back. That's why I didn't propose a PR at the begining.

I am using Gitbucket as VCS. This is actually the same as Github with regards to webhooks and lot more. My issue in this case is the Webhook Call Response returns "/git/my_home_folder/myrepository.git" as "clone_url". The repository full name is "my_home/myrepository". What happens then is that the expected clone_url is then computed to "my_home/myrepository.git". This check fails since the real clone_url is "/git/my_home_folder/myrepository.git".

A similar issue has been described here: #1450

Does it help?

Regards

[candidson]

I have now looked a bit deeper into the source code. What I intend to do wouldn't work at all, since there seems to be strong ties to the pre-defined vcs repos