Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing branch key in the repo section of the docs #1695

Closed
wpbeckwith opened this issue Jul 8, 2021 · 1 comment · Fixed by #1784
Closed

Missing branch key in the repo section of the docs #1695

wpbeckwith opened this issue Jul 8, 2021 · 1 comment · Fixed by #1784
Labels
docs Documentation

Comments

@wpbeckwith
Copy link
Contributor

wpbeckwith commented Jul 8, 2021 •
edited
Loading

The docs section here, https://www.runatlantis.io/docs/server-side-repo-config.html#repo, does not include the 'branch' key in the repo section.
@nishkrishnan
Copy link
Contributor

Probably because there's a bug: #1539

@nishkrishnan nishkrishnan added the docs Documentation label Jul 19, 2021
minamijoyo added a commit to minamijoyo/atlantis that referenced this issue Sep 2, 2021
@minamijoyo
Add missing the branch key in the reference for server side repo co…
8775424 
…nfig

Fixes runatlantis#1695

The branch matcher feature has been implemented in runatlantis#1383 and runatlantis#1768.
There is only an example for it, but not in the reference.

https://github.com/runatlantis/atlantis/pull/1383/files#diff-5dd8dd3b7c37191b78109efaaa1bb73184ff7a1690632d687fed7cd748847f5eR31-R34

Add missing the `branch` key in the reference for server side repo config.

I also add a warning for `mergeable` requirement to check the `branch`
setting because I think a typical branch protection rule only restricts
a default branch. We should let users know that someone can potentially
bypass it without the `branch` restriction in atlantis.
minamijoyo added a commit to minamijoyo/atlantis that referenced this issue Sep 2, 2021
@minamijoyo
Add the branch key in the reference for server side repo config
2db2148 
Fixes runatlantis#1695

The branch matcher feature has been implemented in runatlantis#1383 and runatlantis#1768.
There is only an example for it, but not in the reference.

https://github.com/runatlantis/atlantis/pull/1383/files#diff-5dd8dd3b7c37191b78109efaaa1bb73184ff7a1690632d687fed7cd748847f5eR31-R34

Add missing the `branch` key in the reference for server side repo config.

I also add a warning for `mergeable` requirement to check the `branch`
setting because I think a typical branch protection rule only restricts
a default branch. We should let users know that someone can potentially
bypass it without the `branch` restriction in atlantis.
@minamijoyo minamijoyo mentioned this issue Sep 2, 2021
Merged
nishkrishnan pushed a commit that referenced this issue Sep 14, 2021
@minamijoyo
Add the branch key in the reference for server side repo config (#1784
289cab0 
)

Fixes #1695

The branch matcher feature has been implemented in #1383 and #1768.
There is only an example for it, but not in the reference.

https://github.com/runatlantis/atlantis/pull/1383/files#diff-5dd8dd3b7c37191b78109efaaa1bb73184ff7a1690632d687fed7cd748847f5eR31-R34

Add missing the `branch` key in the reference for server side repo config.

I also add a warning for `mergeable` requirement to check the `branch`
setting because I think a typical branch protection rule only restricts
a default branch. We should let users know that someone can potentially
bypass it without the `branch` restriction in atlantis.
krrrr38 pushed a commit to krrrr38/atlantis that referenced this issue Dec 16, 2022
@minamijoyo @krrrr38
Add the branch key in the reference for server side repo config (ru…
0ce2d62 
…natlantis#1784)

Fixes runatlantis#1695

The branch matcher feature has been implemented in runatlantis#1383 and runatlantis#1768.
There is only an example for it, but not in the reference.

https://github.com/runatlantis/atlantis/pull/1383/files#diff-5dd8dd3b7c37191b78109efaaa1bb73184ff7a1690632d687fed7cd748847f5eR31-R34

Add missing the `branch` key in the reference for server side repo config.

I also add a warning for `mergeable` requirement to check the `branch`
setting because I think a typical branch protection rule only restricts
a default branch. We should let users know that someone can potentially
bypass it without the `branch` restriction in atlantis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add missing the branch key in the reference for server side repo config minamijoyo/atlantis
2 participants
@nishkrishnan @wpbeckwith