Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE-REQUEST] feature flag to disable automerg in PR to apply changes gradually #1245

Closed
balusarakesh opened this issue Oct 30, 2020 · 6 comments
Labels
feature New functionality/enhancement help wanted Good feature for contributors quick-win Is obviously something Atlantis should do and will take <4 hrs work

Comments

@balusarakesh
Copy link

It would be nice to have a feature flag added to atlantis like autoMerge=False or --auto-merge-disabledwhich will disable that specific PR from being merged after a successful apply, this will allow us to test the applied changes and merge the PR manually in cases where you want to iterate on changes as you progress with the PR

@acastle
Copy link
Contributor

acastle commented Dec 4, 2020

@balusarakesh thank you for the suggestion! This does feel like a gap in the current auto merge functionality and is definitely a common feature seen in other tools in the build and release pipeline.

@acastle acastle added feature New functionality/enhancement help wanted Good feature for contributors quick-win Is obviously something Atlantis should do and will take <4 hrs work labels Dec 4, 2020
@red8888
Copy link

red8888 commented Jan 5, 2021

isnt this default behavior? just leave automerge: true out of your config and dont use automerge right?

spirosoik added a commit to spirosoik/atlantis that referenced this issue Apr 26, 2021
```
atlantis apply --auto-merge-disabled
```

Issue: runatlantis#1245
spirosoik added a commit to spirosoik/atlantis that referenced this issue Apr 26, 2021
```
atlantis apply --auto-merge-disabled
```

Issue: runatlantis#1245
spirosoik added a commit to spirosoik/atlantis that referenced this issue Apr 26, 2021
```
atlantis apply --auto-merge-disabled
```

Issue: runatlantis#1245
nishkrishnan pushed a commit that referenced this issue Jun 22, 2021
```
atlantis apply --auto-merge-disabled
```

Issue: #1245
@spirosoik
Copy link
Contributor

we can close this issue

@balusarakesh
Copy link
Author

thank you all for this ❤️

@jeff-clearcover
Copy link

I know this is old but this flag reads confusing, can we potentially change this flag to --disable-auto-merge or support this as well?

@nitrocode
Copy link
Member

@jeff-clearcover please create a new issue and or propose a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement help wanted Good feature for contributors quick-win Is obviously something Atlantis should do and will take <4 hrs work
Projects
None yet
Development

No branches or pull requests

6 participants