Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More complete ruff rule set #7970

Merged
merged 4 commits into from
Oct 4, 2023
Merged

More complete ruff rule set #7970

merged 4 commits into from
Oct 4, 2023

Conversation

jamesbraza
Copy link
Collaborator

Description

Used the script I made in astral-sh/ruff#7805 to enable more ruff rules that don't error. In other words, what more ruff rules can we get, for free?

This PR:

  • Adds more ruff rules, and some to ignore explaining why
  • Syncs black version in requirements.txt with pre-commit

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

@jamesbraza jamesbraza marked this pull request as draft October 4, 2023 19:15
@jamesbraza jamesbraza marked this pull request as ready for review October 4, 2023 19:48
@logan-markewich logan-markewich merged commit 82892e9 into run-llama:main Oct 4, 2023
@jamesbraza jamesbraza deleted the more-ruff branch October 4, 2023 20:04
@danielchalef danielchalef mentioned this pull request Oct 8, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logan-markewich logan-markewich logan-markewich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @logan-markewich