Adjustments to support WSL environements #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added docs Added gitops args for port forward
Added host 0.0.0.0 to docker run Removed un-used gitops flag
rumstead
reviewed
Nov 28, 2023
Updated gateway documentation Removed -h 0.0.0.0 from container run
rumstead
approved these changes
Nov 29, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WSL distros, host.docker.internal does not exist, so I implemented an additional argument to be injected in the shell script that add a cluster to Argocd.
Additionally, when port forward from WSL distros, looks like the system binds only to ipv6
[::1]and not ipv4127.0.0.1, so we needed to explicitly bind the port forward to 0.0.0.0 (--address 0.0.0.0).For the same reason, the Argocd tools container needs to run under host mode with flag
-h 0.0.0.0, so that processes inside the container can access the docker network.Lastly, I added a flag to opt out from port forward in case we can make ingress work with Argocd and k3d. And added the an extra env variable for the container argocd cli calls so that we can include any other argocd flags (i.e.
--grpc-web)