Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement as higher order module #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

rt2zz
Copy link

@rt2zz rt2zz commented Sep 3, 2016

  • proxies through all 7 redux-persist exports
  • merges in immutable config for createPersistor, persistStore, and autoRehydrate

notes:

  • I added one overly basic test, so this could definitely use more testing both of the automated and manual variety.
  • I recommend we rename this project to redux-persist-immutable
  • It feels like REHYDRATE should fire with an immutable map, but to achieve this we would need to add yet another state operator to createPersistor config. Not sure...

@rufman
Copy link
Owner

rufman commented Sep 20, 2016

One though I had (which I haven't really thought out to completion) is implementing this more like a redux store enhancer. That way the redux-persist version used isn't tied to the version used by this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants