Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow only string as argument in Reindex->setRefresh() #1758

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Allow only string as argument in Reindex->setRefresh() #1758

merged 2 commits into from
Feb 17, 2020

Conversation

renanbr
Copy link
Contributor

@renanbr renanbr commented Feb 12, 2020

Follow up #1752 (comment)

@renanbr renanbr mentioned this pull request Feb 12, 2020
Merged
@thePanz
Copy link
Collaborator

thePanz commented Feb 13, 2020

@renanbr can you rebase this? We moved the code from lib/Elastica/ to src/, and the tests fom test/Elastica/totests/`

@thePanz thePanz self-requested a review February 13, 2020 08:12
thePanz
thePanz requested changes Feb 14, 2020
View reviewed changes
Copy link
Collaborator

@thePanz thePanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it requires a rebase as the source code moved to `src/'

@renanbr renanbr force-pushed the reindex-setrefresh-signature branch from 14377ca to e9151b0 Compare February 17, 2020 09:20
@renanbr renanbr force-pushed the reindex-setrefresh-signature branch from e9151b0 to 5dfd8d0 Compare February 17, 2020 09:23
@thePanz thePanz merged commit 962ce53 into ruflin:master Feb 17, 2020
@thePanz
Copy link
Collaborator

thePanz commented Feb 18, 2020

Thanks @renanbr , merged! :)

@renanbr renanbr deleted the reindex-setrefresh-signature branch October 22, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePanz thePanz thePanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renanbr @thePanz