-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for PHP 7.1 #1703
Drop support for PHP 7.1 #1703
Conversation
89b2dbc
to
a4d1f23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -16,7 +16,6 @@ env: | |||
- DOCKER_VERSION=17.09.0 | |||
- DOCKER_COMPOSE_VERSION=1.17.1 | |||
matrix: | |||
- TARGET="71" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this all work but keep this target + the Docker file in? Or will all the tests fail because of the composer requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this won't work because of the composer requirement, at least if --ignore-platform-reqs
is not used
a4d1f23
to
3c39813
Compare
A few general questions:
I'm good with moving forward with this PR. In the past what I did was that what we test and what is "supported" was not necessarily the same. This meant as soon as we introduced a feature that actually broke a previous PHP version we knew and then removed the testing. Like this it was easy to communicate what broke it. |
@ruflin I'm not an expert on the subject but here some stats from composer: https://blog.packagist.com/php-versions-stats-2019-1-edition/ Upgrading to PHP 7.2 should be pretty straightforward. I think it could be judicious to really remove PHP 7.1 support as you are about to publish a new major version. This also brings opportunity to boost PHP 7.2 adoption if users of packages need this new version, which is good for the PHP community. I see two PHP 7.2 features that could be used: |
@deguif Thanks for sharing the additional details. I especially like the point around boosting adoption of 7.2. |
Follow up of #1701