Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test v5 on PHP 7.3 #1647

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Test v5 on PHP 7.3 #1647

merged 2 commits into from
Aug 7, 2019

Conversation

jdreesen
Copy link
Contributor

@jdreesen jdreesen commented Jul 9, 2019

Test the v5 branch on PHP 7.3 too.

@p365labs p365labs self-requested a review August 6, 2019 05:24
@p365labs
Copy link
Collaborator

p365labs commented Aug 6, 2019

@jdreesen can u please update the changelog?

@jdreesen
Copy link
Contributor Author

jdreesen commented Aug 6, 2019

The build failure on PHP 7.0 is unrelated.

@jdreesen
Copy link
Contributor Author

jdreesen commented Aug 6, 2019

Seems it was just a hiccup on travis.

@p365labs
Copy link
Collaborator

p365labs commented Aug 6, 2019

ops... conflict. need to rebase

@jdreesen
Copy link
Contributor Author

jdreesen commented Aug 6, 2019

Rebased.

@p365labs p365labs merged commit 496307b into ruflin:5.x Aug 7, 2019
@jdreesen jdreesen deleted the test-v5-on-php73 branch August 7, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants