avm2: Better trait verification #17119

Lord-McSweeney · 2024-07-14T18:16:10Z

Fixes #8851, should fix #18689

Lord-McSweeney · 2024-07-14T19:46:57Z

Undrafted as I still can't figure out where exactly avmplus does the eagerish return type lookup :/

tests/tests/swfs/avm2/sub_super_same_field/test.toml

core/src/avm2/class.rs

core/src/avm2/script.rs

core/src/avm2/class.rs

adrian17 · 2025-02-20T20:14:19Z

core/src/avm2/script.rs

+        class.validate_class(activation)?;
+        c_class.validate_class(activation)?;
+
+        class.init_vtable(activation.context)?;


Can we add a comment that in FP, finalizing the mapping is lazy?
(at least that's how I remember it, right?)

…ce to `Class::validate_class`

…rototype` infallible

@torokati44

------------------------------------------------------------------------------------------ dolphin-emu.mk 01099d67cbc921176a760b2246d8591aec0983be # Version: Commits on Feb 21, 2025 ------------------------------------------------------------------------------------------ Merge pull request #13326 from nlebeck/taskviewmodel-mustrestartapp Eliminate TaskViewModel's `mustRestartApp` field, ------------------------------------------------------------------------------------------ duckstation.mk 3ea26cc9108256270ae1d1953919b12c6809866e # Version: Commits on Feb 21, 2025 ------------------------------------------------------------------------------------------ GPU: Rewrite automatic resolution scaling Make it play nice with rewind/runahead., ------------------------------------------------------------------------------------- ikemen.mk d8b409c07d978b4e59279f3319fa95cefa9d24b0 # Version: Commits on Feb 20, 2025 ------------------------------------------------------------------------------------- Merge pull request #2334 from Jesuszilla/new-feats fix: Refactored the BindToParent/Root fix to more sensible logic, added missing bind checks for PosSet Z, ----------------------------------------------------------------------------------------- lightspark.mk 5c4273553580ba23198a5ac97b29d907014c4250 # Version: Commits on Feb 20, 2025 ----------------------------------------------------------------------------------------- [MovieClip] Call the parent class' version of `afterLegacyDelete()` Not sure how this wasn't noticed earlier. This allows Super Mario 63's HUD text to actually update., -------------------------------------------------------------------------------------- melonds.mk 63b468927e1c744e21057ccb4c5677f52502b442 # Version: Commits on Feb 21, 2025 -------------------------------------------------------------------------------------- ci: enable building of appimages on aarch64 Looks like whatever was causing linuxdeploy to crash got fixed, so we can build them now., ---------------------------------------------------- pcsx2.mk v2.3.168 # Version: Commits on Feb 21, 2025 ---------------------------------------------------- - [wayland: fix and enable by default](PCSX2/pcsx2#12333) ------------------------------------------------------------------------------------- ppsspp.mk 16d866a4828641afef181c27dbbc50cb5ad2b44b # Version: Commits on Feb 21, 2025 ------------------------------------------------------------------------------------- Merge pull request #20016 from hrydgard/android-scaling-fixes Android: Rework how DPI and Android hardware scaling interacts., ------------------------------------------------------------------------------------ rpcs3.mk 86a832da29316f7b6c15ca9b0f2639e23e74a9e0 # Version: Commits on Feb 21, 2025 ------------------------------------------------------------------------------------ unpkg: Add support for IDU packages, --------------------------------------------------------------- ruffle.mk nightly-2025-02-21 # Version: Commits on Feb 21, 2025 --------------------------------------------------------------- ## What's Changed * chore: Fix beta clippy lints `manual_div_ceil` and `unneeded_struct_pattern` by @torokati44 in ruffle-rs/ruffle#19564 * build(deps): bump the cargo-minor group across 1 directory with 4 updates by @torokati44 in ruffle-rs/ruffle#19557 * render: Small improvements to render crates by @a1phyr in ruffle-rs/ruffle#19574 * avm2: Better trait verification by @Lord-McSweeney in ruffle-rs/ruffle#17119 ## New Contributors * @a1phyr made their first contribution in ruffle-rs/ruffle#19574 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-02-20...nightly-2025-02-21, ----------------------------------------------------- ryujinx.mk 1.2.411 # Version: Commits on Feb 21, 2025 ----------------------------------------------------- # Canary builds: These builds are experimental and may sometimes not work, use [regular builds](https://github.com/Ryubing/Ryujinx/releases/latest) instead if that sounds like something you don't want to deal with. | Platform | Artifact | |--|--| | Windows 64-bit | [Canary Windows Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.2.411/ryujinx-canary-1.2.411-win_x64.zip) | | Linux 64-bit | [Canary Linux Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.2.411/ryujinx-canary-1.2.411-linux_x64.tar.gz) | | Linux ARM 64-bit | [Canary Linux ARM Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.2.411/ryujinx-canary-1.2.411-linux_arm64.tar.gz) | | macOS | [Canary macOS Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.2.411/ryujinx-canary-1.2.411-macos_universal.app.tar.gz) | **Full Changelog**: Ryubing/Ryujinx@Canary-1.2.410...Canary-1.2.411 -------------------------------------------------------------------------------------- shadps4.mk 9424047214665c8a00b84413a47ef9f7bd02c475 # Version: Commits on Feb 21, 2025 -------------------------------------------------------------------------------------- shader_recompiler: Proper support for inst-typed buffer format operations. (#2469), ------------------------------------------------- vice.mk r45502 # Version: Commits on Feb 21, 2025 ------------------------------------------------- Remove unused Windows-specific file Remove file used for the old 'icon.png' chickenhead logo. git-svn-id: https://svn.code.sf.net/p/vice-emu/code/trunk@45502 379a1393-f5fb-40a0-bcee-ef074d9b53f7, ---------------------------------------------------------------------------------------- pironman5.mk 2b7769adb64e17fc76af5c1aaeebc37e4079e851 # Version: Commits on Feb 20, 2025 ---------------------------------------------------------------------------------------- fix lgpio installation, -------------------------------------------------------------------------------------- pm_auto.mk bb39c835a82b76a7217399dd548cad878ff5c024 # Version: Commits on Feb 20, 2025 -------------------------------------------------------------------------------------- improve oled display when no ip on boot, ------------------------------------------------------------------------------------------- pm_dashboard.mk fab6bed940db1cd30218081c308cf044624d330d # Version: Commits on Feb 21, 2025 ------------------------------------------------------------------------------------------- improve log, ---------------------------------------------------------------------------------------- rtl8812au.mk dabcb74da670a12ca74125588bc89aa8ad086c13 # Version: Commits on Feb 21, 2025 ---------------------------------------------------------------------------------------- support for kernel 6.14 - .get_tx_power, ------------------------------------------------------------------------------------ box64.mk 91b282235b44ae32ec46738fba2d151ace99fb5b # Version: Commits on Feb 21, 2025 ------------------------------------------------------------------------------------ [BOX32][ANDROID][TERMUX] revert previous commit and added a new test for shmat wrapped function (still for #2227), --------------------------------------------------------------------------------------- corsixth.mk 82273234a003e8c2ebebd57f037136257a9a36fe # Version: Commits on Feb 21, 2025 --------------------------------------------------------------------------------------- Merge pull request #2762 from lewri/reroute_spawns Change reroute behaviour on trimmed paths, ------------------------------------------------------------------------------------------ devilutionx.mk 0c381798087dee4ce1d989e1569bc8d66068f2f6 # Version: Commits on Feb 21, 2025 ------------------------------------------------------------------------------------------ Upgrade VCPKG commit for SDL2 2.32.0 This catches up SDL version for MSVC, --------------------------------------------------------------------------------------- etlegacy.mk 14571b72bfb81d8fedb998460a7266fab9c1b77f # Version: Commits on Feb 20, 2025 --------------------------------------------------------------------------------------- app: cleanup, ------------------------------------------------------------------------------------------- jazz2-native.mk 5f23383998df6f887beb2e69bf9f0b3cb5308183 # Version: Commits on Feb 20, 2025 ------------------------------------------------------------------------------------------- Updated translations, ------------------------------------------------ vcmi.mk 1.6.6 # Version: Commits on Feb 21, 2025 ------------------------------------------------ Note: saved games from 1.5 release can be loaded in 1.6 ### Changelog - Player Changelog: [1.6.5 -> 1.6.6](https://github.com/vcmi/vcmi/blob/master/ChangeLog.md#165---166) - Full Changelog: https://github.com/vcmi/vcmi/compare/1.6.5..1.6.6 ### Additional builds       - Android release is available on [Google Play](https://play.google.com/store/apps/details?id=is.xyz.vcmi) - Linux release is available on [Flathub](https://flathub.org/apps/eu.vcmi.VCMI) - Ubuntu release is available on [VCMI PPA](https://launchpad.net/~vcmi/+archive/ubuntu/ppa) - macOS release can be installed via Homebrew: `brew install --cask --no-quarantine vcmi/vcmi/vcmi`, ---------------------------------------------------------------------------------------------------- sdl2-gamecontrollerdb.mk 6c9d4e279d96f47566d44989d308d60aa39b8415 # Version: Commits on Feb 21, 2025 ---------------------------------------------------------------------------------------------------- add PowerA Xbox Series X (#832) * add PowerA Xbox Series X * Remove CRC --------- Co-authored-by: Alynne <[email protected]>, --------------------------------------------------------------------------------------- hid-t150.mk 8266ddd9742cb11289c2b23054ea0338911f6dcb # Version: Commits on Feb 21, 2025 --------------------------------------------------------------------------------------- Remove deprecated options, ---------------------------------------------------------------------------------------- retroarch.mk 9005e1b9fedf4794cada6c739f1e4058256e03ea # Version: Commits on Feb 21, 2025 ---------------------------------------------------------------------------------------- Use correct key into message data to get last asset fetch time (#17607), ------------------------------------------------------------------------------------ box86.mk ba5b9e9954deedde62a1378d036405a51792bb37 # Version: Commits on Feb 21, 2025 ------------------------------------------------------------------------------------ Fixed a potential issue with findBlockHinted (for #1031), ------------------------------------------------------------------------------------- gzdoom.mk d9c224439dc00ea288426ffbb4664b499d95dd6c # Version: Commits on Feb 21, 2025 ------------------------------------------------------------------------------------- don't allow changing out-ness of parameters in virtual overrides, ----------------------------------------------------------------------------------- tr1x.mk ed2281d1d7b20b7ace77947838aac7a13d978ebd # Version: Commits on Feb 21, 2025 ----------------------------------------------------------------------------------- tr2/commands: add /wireframe and /cheats Resolves #2500., ----------------------------------------------------------------------------------- tr2x.mk ed2281d1d7b20b7ace77947838aac7a13d978ebd # Version: Commits on Feb 21, 2025 ----------------------------------------------------------------------------------- tr2/commands: add /wireframe and /cheats Resolves #2500., ------------------------------------------------------------------------------------------------ libretro-gambatte.mk addae882e514da769bce6212ee6f7b05a2fcaa7f # Version: Commits on Feb 21, 2025 ------------------------------------------------------------------------------------------------ Fetch translations & Recreate libretro_core_options_intl.h, -------------------------------------------------------------------------------------------------- libretro-gearsystem.mk 39e1927ed90aad5863240cf3b25ceb3d8a8bdc15 # Version: Commits on Feb 20, 2025 -------------------------------------------------------------------------------------------------- Better ram mirror support in Jumbo Dahjee mapper, ---------------------------------------------------------------------------------------------- libretro-ppsspp.mk 16d866a4828641afef181c27dbbc50cb5ad2b44b # Version: Commits on Feb 21, 2025 ---------------------------------------------------------------------------------------------- Merge pull request #20016 from hrydgard/android-scaling-fixes Android: Rework how DPI and Android hardware scaling interacts.,

Lord-McSweeney marked this pull request as ready for review July 14, 2024 19:35

torokati44 force-pushed the avm2-verifier-more-verifi branch from 3b5963f to eae405f Compare July 15, 2024 10:16

adrian17 requested changes Jul 23, 2024

View reviewed changes

tests/tests/swfs/avm2/sub_super_same_field/test.toml Show resolved Hide resolved

core/src/avm2/class.rs Outdated Show resolved Hide resolved

adrian17 reviewed Jul 23, 2024

View reviewed changes

core/src/avm2/script.rs Show resolved Hide resolved

Lord-McSweeney marked this pull request as draft September 2, 2024 23:41

danielhjacobs added A-avm2 Area: AVM2 (ActionScript 3) T-fix Type: Bug fix (in something that's supposed to work already) labels Sep 17, 2024

n0samu mentioned this pull request Nov 20, 2024

Error while running sparkweb #18689

Closed

Lord-McSweeney force-pushed the avm2-verifier-more-verifi branch from eae405f to 8f21fd0 Compare February 8, 2025 17:36

Lord-McSweeney marked this pull request as ready for review February 8, 2025 18:57

Lord-McSweeney force-pushed the avm2-verifier-more-verifi branch 2 times, most recently from 7cc3fa7 to e3be3bb Compare February 8, 2025 19:57

Lord-McSweeney added the waiting-on-review Waiting on review from a Ruffle team member label Feb 10, 2025

adrian17 approved these changes Feb 20, 2025

View reviewed changes

Lord-McSweeney enabled auto-merge (rebase) February 20, 2025 21:18

Lord-McSweeney added 6 commits February 20, 2025 13:18

avm2: Ensure hasnext2 uses two different registers for object and index

751c890

avm2: Prevent slot ops from being called with a slot index of 0

3b89afb

avm2: Improve class trait verification

b16e22e

avm2: Move code verifying that superclass is neither final or interfa…

0e46856

…ce to `Class::validate_class`

avm2: Make ClassObject::from_class_partial and `ClassObject::link_p…

5ebe6d9

…rototype` infallible

tests: avm2/sub_super_same_field now passes

f048c67

Lord-McSweeney force-pushed the avm2-verifier-more-verifi branch from e3be3bb to f048c67 Compare February 20, 2025 21:19

Lord-McSweeney merged commit ff75da2 into ruffle-rs:master Feb 20, 2025
22 checks passed

n0samu added newsworthy and removed waiting-on-review Waiting on review from a Ruffle team member labels Feb 21, 2025

adrian17 mentioned this pull request Feb 23, 2025

avm2: Set correct version to Socket::timeout #19610

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

avm2: Better trait verification #17119

avm2: Better trait verification #17119

Lord-McSweeney commented Jul 14, 2024 •

edited

Loading

Lord-McSweeney commented Jul 14, 2024 •

edited

Loading

adrian17 Feb 20, 2025

avm2: Better trait verification #17119

avm2: Better trait verification #17119

Conversation

Lord-McSweeney commented Jul 14, 2024 • edited Loading

Lord-McSweeney commented Jul 14, 2024 • edited Loading

adrian17 Feb 20, 2025

Choose a reason for hiding this comment

Lord-McSweeney commented Jul 14, 2024 •

edited

Loading

Lord-McSweeney commented Jul 14, 2024 •

edited

Loading