Use GitHub Action instead of travis-ci.org #515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI doesn't work against recent PRs because building on travis-ci.org is ceased. We can use travis-ci.com instead of travis-ci.org, but it has limitations to build time. So I think using GitHub Actions is the best CI to build this repository. I migrated the settings while maintaining the original state as much as possible. Improvements to the configuration, such as adding Rails 7.0, will be done in the next PR.
|
You can check the test results of this PR here. Use GitHub Action instead of travis-ci.org · willnet/paranoia@5689e21 |
mathieujobin
reviewed
Nov 4, 2021
.github/workflows/test.yml
Outdated
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
20.04 sounds a better bet for something aimed at servers
mathieujobin
reviewed
Nov 4, 2021
| - 2.3.8 | ||
| - 2.4.5 | ||
| - 2.5.3 | ||
| - 2.6.3 |
There was a problem hiding this comment.
shall we take the opportunity to remove 2.3, and 2.4, add 2.7 and 3.0 ?
separate PR is better?
mathieujobin
reviewed
Nov 4, 2021
| - ruby-version: '2.4.5' | ||
| gemfile: rails_6_0 | ||
| - ruby-version: '2.4.5' | ||
| gemfile: rails_6_1 |
There was a problem hiding this comment.
I think that was neat how they made it work with ENV vars for travis. it should be possible to keep the same pattern with github actions, at least that's what I am trying
|
👍 on switching to Github actions. Run build is here https://github.com/willnet/paranoia/actions/runs/1302894789 All test pass ! shall we remove the |
|
Alternative #516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI doesn't work against recent PRs because building on travis-ci.org is ceased.
We can use travis-ci.com instead of travis-ci.org, but it has limitations to build time. So I think using GitHub Actions is the best CI to build this repository.
I migrated the settings while maintaining the original state as much as possible. Improvements to the configuration, such as adding Rails 7.0, will be done in the next PR.